? Failure

User tests: Successful: Unsuccessful:

avatar LLNet
LLNet
17 Oct 2014

Remove php closing tag

at the end of these files are php end tag removed.

so simple

avatar LLNet LLNet - open - 17 Oct 2014
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 17 Oct 2014
Category Code style
avatar infograf768
infograf768 - comment - 17 Oct 2014

Please do not touch at 3rd party libraries.

avatar LLNet
LLNet - comment - 17 Oct 2014
avatar allanlhansen allanlhansen - test_item - 17 Oct 2014 - Tested successfully
avatar zero-24
zero-24 - comment - 17 Oct 2014

@LLNet looks like travis is not happy :smile:

FILE: ...ravis/build/joomla/joomla-cms/layouts/joomla/tinymce/buttons/button.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 14 | ERROR | Additional whitespace found at end of file
--------------------------------------------------------------------------------
FILE: /home/travis/build/joomla/joomla-cms/layouts/joomla/tinymce/buttons.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 14 | ERROR | Additional whitespace found at end of file
--------------------------------------------------------------------------------

Can you fix it?

Also please remove / ignore idna_convert, phpass and simplepie from / in your PR.

avatar brianteeman brianteeman - alter_testresult - 18 Oct 2014 - allanlhansen: Not tested
avatar brianteeman
brianteeman - comment - 18 Oct 2014

Resetting tests as this will need to be retested when an updated PR is submitted

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4760.

avatar LLNet LLNet - close - 18 Oct 2014
avatar LLNet LLNet - change - 18 Oct 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-18 10:15:30

Add a Comment

Login with GitHub to post a comment