User tests: Successful: Unsuccessful:
Pull Request resolves #47515
This pull request implements error handling for punycode conversions of URLs by catching exceptions to prevent crash.
In UrlFilter.php, a try...catch block has been added around PunycodeHelper::urlToPunycode() to silently handle conversion exceptions
In UrlRule.php, the host validation logic has been updated to split the hostname into individual labels and test the punycode conversion for each using PunycodeHelper::toPunycode(). Any exception thrown during this process is caught, properly resulting in a validation failure, instead of a unhandled application crash.
Minor code style formatting for the $scheme array in UrlRule.php
Try saving a url type form field <input type="url" inputmode="url"> (ex: the "Website" field in the Edit Contact form).
Enter a URL with an invalid hostname character (like an apostrophe), for example:
https://example'test.com
Fatal error / application crash ( ex: 101 Prohibited input U+00000027)
No crash. Appropriate error message is shown ( Invalid field: Website)
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
I have tested this item ✅ successfully on 446c631
Thanks!
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-6.0-dev
|
||
RTC
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-04-15 06:25:20 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
RTC
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2026-04-15 06:25:20 | ⇒ | |
| Closed_By | bembelimen | ⇒ | |
| Labels |
Removed:
RTC
|
||
| Status | New | ⇒ | Pending |
Sorry my fault, missed this PR when deleting the branch.
Sorry my fault, missed this PR when deleting the branch.
you closed a few other pr - i assume the same reason
| Title |
|
||||||
@bembelimen
When this was deleted the RTC tag got removed aswell, can you please reassign it.
| Status | Pending | ⇒ | Ready to Commit |
Back to RTC
I have tested this item ✅ successfully on 446c631
Test by using the custom update server.
Thanks @hiteshm0 for the Pull Request.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47557.