[#47516] - Fix: expired articles show published icon in Single Article menu item…
- Pending
- Medium
- Build: 5.4-dev
- # 47516
- Diff
- kiruthika-cse-cs:fix/expired-articles-icon-47489
User tests: Successful: Unsuccessful:
… selector #47489
Pull Request resolves #47489.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Expired articles were displaying a green published icon instead of the
expired icon when selecting an article for a Single Article menu item.
Added a check for the publish_down date against the current date before
assigning the icon class, so expired articles now correctly display the
expired icon.
Fixes #47489
Testing Instructions
- Create an article with a publish_down date in the past
- Create a new menu item of type Single Article
- Click Select Article to open the modal
- Find the expired article
- It should now show the expired icon instead of published icon
Actual result BEFORE applying this Pull Request
Expired articles show green published icon (icon-publish)
Expected result AFTER applying this Pull Request
Expired articles show expired icon (icon-expired)
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Screenshots
Before fix:
After fix:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
@drmenzelit Thank you for the suggestion. I will check how the expired state is handled in the articles list and see whether the same logic can be reused here for consistency.
@kiruthika-cse-cs My above change suggestions are just for you to see what should be changed on the current code of this PR so you can learn. But what @drmenzelit is still right, please check if you can re-use code from the articles list.
@kiruthika-cse-cs Other question: Looking at your code changes, they look identical with those of the older PR #47491 . What am I missing?
Have you checked how it is done in the articles list and f you can re-use the code there?