Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4751] - Fixed validation message display

? Success
Related to # 4735

User tests: Successful: Unsuccessful:

avatar Nokkaew
Nokkaew
17 Oct 2014

fixed validation message display
http://issues.joomla.org/tracker/joomla-cms/4735

Original Report

Steps to reproduce the issue

  1. Go to Menu->Main Menu-> Add New Menu Item.
  2. Open Add New Menu Item form.
  3. Do not Fill the data in title field and click on save button.
  4. Incorrect validation message is displayed as follow: Error Invalid form

Expected result

Validation message should be user friendly like "invalid field: title"

Actual result

Incorrect validation message is displayed as follow:
Error
Invalid form

System information (as much as possible)

PHP Built On Windows NT 6.2 build 9200
Database Version 5.6.12-log
Database Collation utf8_general_ci
PHP Version 5.4.12
Web Server Apache/2.4.4 (Win64) PHP/5.4.12
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.3.7-dev Development [ Ember ] 01-October-2014 02:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 6.1; rv:32.0) Gecko/20100101 Firefox/32.0screen shot 2014-10-17 at 03 17 42

Additional comments

Validation message should be user friendly.

Votes

# of Users Experiencing Issue
1/2
Average Importance Score
3.00
avatar Nokkaew Nokkaew - open - 17 Oct 2014
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 17 Oct 2014
Rel_Number ⇒ 4735
Relation Type ⇒ Related to
avatar brianteeman brianteeman - change - 17 Oct 2014
Category ⇒ Administration
avatar brianteeman brianteeman - change - 17 Oct 2014
The description was changed
avatar joomlacorner joomlacorner - test_item - 17 Oct 2014 - Tested successfully
avatar 1apweb 1apweb - test_item - 17 Oct 2014 - Tested successfully
avatar pete-rossetti pete-rossetti - test_item - 17 Oct 2014 - Tested successfully
avatar pete-rossetti
pete-rossetti - comment - 17 Oct 2014

Error message now Invalid Menu Title

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4751.

avatar LLNet LLNet - test_item - 17 Oct 2014 - Tested successfully
avatar LLNet LLNet - test_item - 17 Oct 2014 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 Oct 2014

Multiple successful tests - thanks - setting to RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4751.

avatar brianteeman brianteeman - change - 17 Oct 2014
Status Pending ⇒ Ready to Commit
avatar LLNet
LLNet - comment - 17 Oct 2014

Have tested it and it works :)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4751.

avatar seakson seakson - test_item - 17 Oct 2014 - Tested successfully
avatar infograf768
infograf768 - comment - 17 Oct 2014

Codestyle:
Please use
elseif (

avatar cobrp cobrp - test_item - 17 Oct 2014 - Tested unsuccessfully
avatar zero-24 zero-24 - change - 17 Oct 2014
Title
…
Update edit.php
Fixed validation message display
avatar zero-24
zero-24 - comment - 17 Oct 2014

@cobrp please share the details why/how your test fail.

cobrp - test_item - 17 Oct 14 - Tested unsuccessfully

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4751.

avatar revers28 revers28 - test_item - 17 Oct 2014 - Tested successfully
avatar larapetersen
larapetersen - comment - 17 Oct 2014

@test
Tested succesfully(Chrome).

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4751.

avatar larapetersen larapetersen - test_item - 17 Oct 2014 - Tested successfully
avatar shantanutekdi shantanutekdi - test_item - 18 Oct 2014 - Tested successfully
avatar sagarch
sagarch - comment - 18 Oct 2014

Tested successfully(chrome)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4751.

avatar sagarch sagarch - test_item - 18 Oct 2014 - Tested successfully
avatar aniket19491 aniket19491 - test_item - 18 Oct 2014 - Tested successfully
avatar aniket19491 aniket19491 - test_item - 18 Oct 2014 - Tested successfully
avatar twsnikhil twsnikhil - test_item - 18 Oct 2014 - Tested successfully
avatar dgt41
dgt41 - comment - 18 Oct 2014

@zero-24 Actually there is another PR that converts all this to jquery. Can you check #4517 and maybe make there the changes. That one is already RTC

avatar jissues-bot jissues-bot - change - 18 Oct 2014
Labels Added: ?
avatar Nokkaew
Nokkaew - comment - 18 Oct 2014

Thank you for your advice.

avatar Fedik
Fedik - comment - 19 Oct 2014

This should be fixed in #4517 already, but in different way :smile:

Current patch have a problem: it ignore validation result for "modal" fields ... it fix one but break another :smile:

avatar dgt41
dgt41 - comment - 20 Oct 2014

I just want to confirm that #4517 solves this problem, as @Fedik also stated. So I think is better to close this one, as the other fix also removes the mootools dependancy
Before:
screenshot 2014-10-20 12 57 36

Using the #4517 :
screenshot 2014-10-20 13 03 04

avatar zero-24 zero-24 - close - 20 Oct 2014
avatar zero-24 zero-24 - change - 20 Oct 2014
Status Ready to Commit ⇒ Closed
avatar jissues-bot
jissues-bot - comment - 20 Oct 2014

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/4751

avatar jissues-bot jissues-bot - close - 20 Oct 2014
avatar zero-24
zero-24 - comment - 20 Oct 2014

Closing as we have a also RTC PR that fix the same issue but removes the mootools dependency as noted by @dgt41 Thanks.

avatar jissues-bot jissues-bot - change - 20 Oct 2014
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-10-20 10:16:29
avatar zero-24 zero-24 - change - 1 Apr 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment