RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar krishnagandhicode
krishnagandhicode
30 Mar 2026

Pull Request resolves #35252

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

when a required modal field is left empty, the field is now visibly marked invalid with this fix.
As discussed in issue #35252 for Articles - Categories the issue is no longer reproducible on current branches because Parent Category is optional there, but the issue stil exists on required modal fields for instance User Notes.

Testing Instructions

Navigate to users > users notes > create new
fill user field (select any user ) but leave the category field empty and click save or save&close

Actual result BEFORE applying this Pull Request

form is blocked with the erroe message :
"The form cannot be submitted as it's missing required data.
Please correct the marked fields and try again"

But the visible required field (Category) is not clearly marked invalid
image

Expected result AFTER applying this Pull Request

Form is blocked.
Category field is visibly marked invalid.
image

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar krishnagandhicode krishnagandhicode - open - 30 Mar 2026
avatar krishnagandhicode krishnagandhicode - change - 30 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2026
Category Layout
avatar krishnagandhicode krishnagandhicode - change - 30 Mar 2026
The description was changed
avatar krishnagandhicode krishnagandhicode - edited - 30 Mar 2026
avatar brianteeman brianteeman - test_item - 30 Mar 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 Mar 2026

I have tested this item ✅ successfully on 358b6e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47505.

avatar brianteeman
brianteeman - comment - 30 Mar 2026

Thanks - the required markup is now in the correct place

avatar exlemor exlemor - test_item - 30 Mar 2026 - Tested successfully
avatar exlemor
exlemor - comment - 30 Mar 2026

I have tested this item ✅ successfully on 358b6e3

I have tested this successfully! Nice job @krishnagandhicode!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47505.

avatar richard67 richard67 - change - 30 Mar 2026
Status Pending Ready to Commit
Labels Added: PR-5.4-dev
avatar richard67
richard67 - comment - 30 Mar 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47505.

avatar drmenzelit drmenzelit - change - 31 Mar 2026
Title
[5.4] Fix required modal categroy field highlighting on validation error
[5.4] Fix required modal category field highlighting on validation error
avatar drmenzelit drmenzelit - edited - 31 Mar 2026
avatar muhme muhme - change - 1 Apr 2026
Labels Added: RTC bug
avatar muhme
muhme - comment - 1 Apr 2026

✅ Final test before merge with JBT

  • Seen User Notes with not-marked missing fields before PR
  • Applied PR with Patch Tester
    • User Notes – one or two missing fields are correct red marked label and field, saveable after inserting mandatory data
    • Other places (User, Group, Articles Site Module) still correct marking and saveable after inserting mandatory data
avatar muhme muhme - change - 1 Apr 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-04-01 16:17:37
Closed_By muhme
avatar muhme muhme - close - 1 Apr 2026
avatar muhme muhme - merge - 1 Apr 2026
avatar muhme
muhme - comment - 1 Apr 2026

Thank you very much @krishnagandhicode for your contribution. Thanks to @brianteeman and @exlemor for testing.

avatar krishnagandhicode
krishnagandhicode - comment - 1 Apr 2026

Thanks for the merge, and thanks to everyone who helped test : )

Add a Comment

Login with GitHub to post a comment