? Error
Referenced as Related to: # 4740

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
17 Oct 2014

#4740

result after patch when no record:
screen shot 2014-10-17 at 12 26 14

avatar infograf768 infograf768 - open - 17 Oct 2014
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Labels Added: ?
avatar LLNet LLNet - test_item - 17 Oct 2014 - Tested successfully
avatar brianteeman brianteeman - change - 17 Oct 2014
Category Administration UI/UX
avatar LLNet
LLNet - comment - 17 Oct 2014

it works but why should it only be on "this page" on users in administrator ?screen shot 2014-10-17 at 05 48 58

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4749.

avatar infograf768
infograf768 - comment - 17 Oct 2014

It is used on many pages in back-end.
Some are missing and we have to make a patch per page.

avatar LLNet
LLNet - comment - 17 Oct 2014

Ok :)

avatar joomdonation
joomdonation - comment - 17 Oct 2014

@test: OK. So you can merge it .

avatar brianteeman brianteeman - change - 17 Oct 2014
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 17 Oct 2014

Setting to RTC - thanks for testing

avatar infograf768
infograf768 - comment - 17 Oct 2014

Travis fails here but it is not related to the PR

avatar joomdonation
joomdonation - comment - 17 Oct 2014

@infograf768 Do you know whether we need to check codestyle for layout files ? I want to do the same for contacts and newsfeeds components but seems there are many code styles warning when run phpcs ?

avatar infograf768
infograf768 - comment - 17 Oct 2014

the rule for layouts is mostly to indent correctly. Look at existing layouts.

avatar infograf768 infograf768 - close - 17 Oct 2014
avatar infograf768 infograf768 - change - 17 Oct 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-10-17 11:27:06
avatar roland-d
roland-d - comment - 17 Oct 2014

@joomdonation Layout files can be codestyle checked but only for the basics since there is no definite ruleset yet for files where PHP and HTML is mixed. As for the components, they have all been done during the code style sprint last weekend. There should be still PRs for these components, if not yet merged. In case they are merged, then it is a new issue of course.

avatar joomdonation
joomdonation - comment - 17 Oct 2014

Thanks @infograf768 and @roland-d. Tried to download the file administrator\components\com_contact\views\contacts\tmpl\default.php from staging, then run codestyle check on my local computer but there are still many errors and warnings. The codestyle rules I downloaded from https://github.com/joomla/coding-standards, not sure it is the one we are using for layout files as well ? Or layout uses different rules ?

avatar roland-d
roland-d - comment - 21 Oct 2014

@joomdonation You have the correct coding standards but they do not apply to the files in the tmpl folders as this is a mix of both PHP and HTML. Only a small subset of our coding standard is currently used for the tmpl files, as there is no definite code style set for tmpl files yet.

avatar joomdonation
joomdonation - comment - 21 Oct 2014

@roland-d: Thanks for letting me know :)

Add a Comment

Login with GitHub to post a comment