User tests: Successful: Unsuccessful:
Labels |
Added:
?
|
Category | ⇒ | Administration UI/UX |
It is used on many pages in back-end.
Some are missing and we have to make a patch per page.
Ok :)
Status | Pending | ⇒ | Ready to Commit |
Setting to RTC - thanks for testing
Travis fails here but it is not related to the PR
@infograf768 Do you know whether we need to check codestyle for layout files ? I want to do the same for contacts and newsfeeds components but seems there are many code styles warning when run phpcs ?
the rule for layouts is mostly to indent correctly. Look at existing layouts.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-17 11:27:06 |
@joomdonation Layout files can be codestyle checked but only for the basics since there is no definite ruleset yet for files where PHP and HTML is mixed. As for the components, they have all been done during the code style sprint last weekend. There should be still PRs for these components, if not yet merged. In case they are merged, then it is a new issue of course.
Thanks @infograf768 and @roland-d. Tried to download the file administrator\components\com_contact\views\contacts\tmpl\default.php from staging, then run codestyle check on my local computer but there are still many errors and warnings. The codestyle rules I downloaded from https://github.com/joomla/coding-standards, not sure it is the one we are using for layout files as well ? Or layout uses different rules ?
@joomdonation You have the correct coding standards but they do not apply to the files in the tmpl folders as this is a mix of both PHP and HTML. Only a small subset of our coding standard is currently used for the tmpl files, as there is no definite code style set for tmpl files yet.
it works but why should it only be on "this page" on users in administrator ?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4749.