Seems that there were several changes on this file in #41655 merged into 6.0 which could result in a conflict.

Seems that there were several changes on this file in #41655 merged into 6.0 which could result in a conflict.

That’s then up to the RM.

Could you you trim the left part instead of adding space in the right part?

Maybe refactor it like this?

        $group        = static::$loaded[__CLASS__ . '::startAccordion'][$selector];
        $active       = $group['active'] === $id;
        $in           = $active ? ' show' : '';
        $collapsed    = $active ? '' : ' collapsed';
        $parent       = $group['parent'] ? 'data-bs-parent="' . $group['parent'] . '"' : '';
        $class        = (!empty($class)) ? ' ' . $class : '';
        $ariaExpanded = $active;

Install Blog Sample Data.
Click Components>Smart Search>Filters.
Click Add a filter button.
Use browser's element inspector to see aria-expanded attribute.
It should be true and not 1.

That's fixed now, thanks.

I have tested this item ✅ successfully on ea64c46

I have tested this item ✅ successfully on ea64c46

$collapsed can be refactored/simplified in the same manner.

I have tested this item ✅ successfully on 7f4b946

I have tested this item ✅ successfully on 7f4b946

@QuyTon I've simplified it further. Could you test again, please?

Please fix PHP code style.

please add some test instructions

I have tested this item ✅ successfully on 0adbd20

I have tested this item ✅ successfully on 0adbd20

weird that this problem is not repeatable in j6

@brianteeman thanks for checking. It's broken for me:

Make sure not to toggle the accordion item. It's only broken initially.

@brianteeman thanks for checking. Make sure not to toggle the accordion item. It's only broken initially.

I have tested this item ✅ successfully on 0adbd20

We opened the smart search filter field. We looked for aria-expanded and found two true, around four false and some which had no assigned values.
After the patch there the "not assigned" values were set to either true or false.
It looks like four "false" were kept and one changed to true (could have been empty before

I have tested this item ✅ successfully on 0adbd20

We opened the smart search filter field. We looked for aria-expanded and found two true, around four false and some which had no assigned values.
After the patch there the "not assigned" values were set to either true or false.
It looks like four "false" were kept and one changed to true (could have been empty before

RTC

RTC

✅ Final Test before merge with JBT

• Before PR seen problem initial only 'aria-expanded' without any '="true"' or '="false"'
• Applied PR with Patch Tester
  • Seen initial 'aria-expanded="true"' and is set 'false' for closed control and 'true' again on reopen

Thank you very much @janschoenherr for your contribution. Thank you @QuyTon for reviewing and testing. Thank you @tecpromotion for review. Thanks to @chmst and @brianteeman for supporting. Thank you @ThomasFinnern for testing.