Feeling Lucky
[#47483] - [5.4] Fix aria-expanded check
- Pending
- Medium
- Build: 5.4-dev
- # 47483
- Diff
- janschoenherr:patch-39
User tests: Successful: Unsuccessful:
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Fix aria-expanded check
Testing Instructions
none.
Actual result BEFORE applying this Pull Request
aria-expaded always set to false
Expected result AFTER applying this Pull Request
aria-expaded set to true when active
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
dgrammatiko
- comment
- 29 Mar 2026
Could you you trim the left part instead of adding space in the right part?
janschoenherr
- comment
- 29 Mar 2026
Maybe refactor it like this?
$group = static::$loaded[__CLASS__ . '::startAccordion'][$selector];
$active = $group['active'] === $id;
$in = $active ? ' show' : '';
$collapsed = $active ? '' : ' collapsed';
$parent = $group['parent'] ? 'data-bs-parent="' . $group['parent'] . '"' : '';
$class = (!empty($class)) ? ' ' . $class : '';
$ariaExpanded = $active;
Seems that there were several changes on this file in #41655 merged into 6.0 which could result in a conflict.