? Failure
Referenced as Related to: # 4490

User tests: Successful: Unsuccessful:

avatar madasha
madasha
17 Oct 2014

Adding option to disable mass mail to users option and checks where necessary in order to disable this functionality if the option is disabled. Re: http://issues.joomla.org/tracker/joomla-cms/4490

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar madasha madasha - open - 17 Oct 2014
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Labels Added: ?
avatar dimitargsg
dimitargsg - comment - 17 Oct 2014

@test I tested this patch and it seems to be working properly with Isis:

When disabled: http://awesomescreenshot.com/0b73oeyh94
When enabled: http://awesomescreenshot.com/03f3oeyu02

but with hathor the Mass Mail option is still visible(but does not work as expected):

http://awesomescreenshot.com/02a3of18b7

avatar brianteeman brianteeman - change - 17 Oct 2014
Category Administration Components
avatar hikashop-jerome
hikashop-jerome - comment - 17 Oct 2014

@test the patch remove the "mass-mail" by default in Isis ; so we have to edit the option to have it back.
The default behaviour is not the right one.

avatar brianteeman
brianteeman - comment - 17 Oct 2014

@hikashop-jerome yes the default should be for no change and the option should be to disable

avatar madasha
madasha - comment - 17 Oct 2014

OK, will swap the defaults in a minute.

avatar madasha
madasha - comment - 17 Oct 2014

@dimitargsg, @brianteeman, @hikashop-jerome The functionality is reversed to keep the default behaviour intact, as suggested. Thanks for making the point!
@dimitargsg The Hathor template fix is there too, pls test again.

avatar madasha
madasha - comment - 17 Oct 2014

@zero-24 changes to keep code standard done. Thanks for pointing.

avatar hvdmeer hvdmeer - test_item - 17 Oct 2014 - Tested successfully
avatar hvdmeer
hvdmeer - comment - 17 Oct 2014

@test Followed instructions and applied test. Setting was added to mail settings and I set it to disable. The mass mail was removed from templates Isis and Hathor.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4747.

avatar isyvon
isyvon - comment - 17 Oct 2014

@test I applied the patch and it works with Isis template. The default value for the option is the right one : mass email is activated by default.

avatar brianteeman brianteeman - alter_testresult - 17 Oct 2014 - isyvon: Tested successfully
avatar dimitargsg
dimitargsg - comment - 17 Oct 2014

@test Now it works properly.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4747.

avatar dimitargsg dimitargsg - test_item - 17 Oct 2014 - Tested successfully
avatar brianteeman brianteeman - change - 17 Oct 2014
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 17 Oct 2014

Multiple good tests - thanks everyone - setting to RTC

avatar zero-24
zero-24 - comment - 17 Oct 2014

@madasha we have two more CS issues:


FILE: ...la-cms/administrator/templates/hathor/html/mod_menu/default_enabled.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
  98 | ERROR | Whitespace found at end of line
 100 | ERROR | Tabs must be used to indent lines; spaces are not allowed
--------------------------------------------------------------------------------
FILE: .../joomla-cms/administrator/components/com_users/views/mail/view.html.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 34 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------

See: https://travis-ci.org/joomla/joomla-cms/jobs/38251859

avatar jissues-bot jissues-bot - change - 20 Oct 2014
Labels Added: ?
avatar phproberto phproberto - close - 23 Oct 2014
avatar phproberto phproberto - change - 23 Oct 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-10-23 15:52:32
avatar phproberto
phproberto - comment - 23 Oct 2014

I added some tweaks in 4e8ce96 and merged

Add a Comment

Login with GitHub to post a comment