[#47459] - [7.0] [Target 8.0] Remove ReshapeArgumentsAware and usage and legacy setters
- Pending
- Medium
- Build: 7.0-dev
- Draft PR
- # 47459
- Diff
- Hackwar:7.0-events-deprecated
User tests: Successful: Unsuccessful:
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
This removes the deprecated ReshapeArgumentsAware trait and all its usages from core events. It also removes the legacy setters from the event classes. There are several setters which were public before and are now protected. is that correct?
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org: joomla/Manual#702
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-7.0-dev
|
||
| Labels |
Added:
Feature
b/c break
|
||
There are several setters which were public before and are now protected. is that correct?
Sounds incorrect.
Keep in mind, in the event classes there are callbacks based on argument name, example onSetFoobar() for foobar argument. These callbacks in past were just setFoobar() which looks like setter but they are not. The same for get action.
All protected/private set/get is most likely old callbacks wich can be removed if related onSet/onGet is implemented.
About the publick set/get methods need to be carefull. Some of them may be old callback or new getter/setter that should not be removed.
laoneo
- | Labels |
Added:
Documentation Required
Architecture
|
||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
Sounds incorrect.
Keep in mind, in the event classes there are callbacks based on argument name, example
onSetFoobar()forfoobarargument. These callbacks in past were justsetFoobar()which looks like setter but they are not. The same forgetaction.All protected/private set/get is most likely old callbacks wich can be removed if related
onSet/onGetis implemented.About the publick set/get methods need to be carefull. Some of them may be old callback or new getter/setter.