User tests: Successful: Unsuccessful:
…able preview
Pull Request resolves #45936 .
Removes the readonly TinyMCE editor used to display translated descriptions in guided tours and steps and replaces it with a static html preview. This prevents initialization of a second editor instance, makes the content non editable, preserves rendered html output, and eliminates related accessibility issues and TinyMCE console warnings
A second TinyMCE editor is rendered to display the translated description and there is a console warning that says "Invalid value passed for the readonly option. The value must be a boolean"
The translated description is displayed as a static, non editable preview and no additional TinyMCE editor instance is created with no console warnings.

Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration |
| Labels |
Added:
PR-6.1-dev
|
||
Thanks Adarsh @adarshdubey03, that looks much better to me.
Thank you for giving it a second try!
The initial implementation definitely needs a refresh on that point.
Your PR avoids the loading of an additional disabled editor instance that only needs to replicate what the language key represents.
Ultimately, we should be able to disable an editor field without having a warning in the console. But that is not the point of this PR.
If you are going to remove the editor fields
description_translationfor tours and steps, you also need to remove them from the xml files, since they become useless.They are in
administrator/components/com_guidedtours/forms/tour.xmladministrator/components/com_guidedtours/forms/step.xmlAnd I would probably avoid the use of control-group... here, I would call the layout that render fields
layouts\joomla\form\renderfield.phpto do the formatting for you.
Thanks for looking into this!