PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar adarshdubey03
adarshdubey03
23 Mar 2026

…able preview

Pull Request resolves #45936 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Removes the readonly TinyMCE editor used to display translated descriptions in guided tours and steps and replaces it with a static html preview. This prevents initialization of a second editor instance, makes the content non editable, preserves rendered html output, and eliminates related accessibility issues and TinyMCE console warnings

Testing Instructions

  1. Edit a guided tour step whose description uses a language key and confirm only one editor is shown and the translated description appears below as a non editable preview without a second toolbar or cursor
  2. Edit a step whose description is plain text and confirm only the main editor is displayed.
  3. Create a new step and confirm no preview is shown before saving.
  4. Save the new step with a language key in the description and confirm the preview appears after saving.
  5. Repeat the same checks in guided tours -> tours.
  6. Verify the browser console shows no TinyMCE readonly or duplicate instance warnings.

Actual result BEFORE applying this Pull Request

A second TinyMCE editor is rendered to display the translated description and there is a console warning that says "Invalid value passed for the readonly option. The value must be a boolean"

Expected result AFTER applying this Pull Request

The translated description is displayed as a static, non editable preview and no additional TinyMCE editor instance is created with no console warnings.
image

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar adarshdubey03 adarshdubey03 - open - 23 Mar 2026
avatar adarshdubey03 adarshdubey03 - change - 23 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2026
Category Administration
avatar adarshdubey03 adarshdubey03 - change - 23 Mar 2026
Labels Added: PR-6.1-dev
avatar obuisard
obuisard - comment - 24 Mar 2026

The initial implementation definitely needs a refresh on that point.
Your PR avoids the loading of an additional disabled editor instance that only needs to replicate what the language key represents.

Ultimately, we should be able to disable an editor field without having a warning in the console. But that is not the point of this PR.

If you are going to remove the editor fields description_translation for tours and steps, you also need to remove them from the xml files, since they become useless.

They are in
administrator/components/com_guidedtours/forms/tour.xml
administrator/components/com_guidedtours/forms/step.xml

And I would probably avoid the use of control-group... here, I would call the layout that render fields
layouts\joomla\form\renderfield.php
to do the formatting for you.

Thanks for looking into this!

avatar adarshdubey03
adarshdubey03 - comment - 24 Mar 2026

Hello @obuisard ,
I have removed the unused description_translation editor fields from both xml files and updated the templates to use the core renderfield layout, i hope this addresses the things you have suggessted !!

avatar obuisard
obuisard - comment - 25 Mar 2026

Thanks Adarsh @adarshdubey03, that looks much better to me.
Thank you for giving it a second try!

Add a Comment

Login with GitHub to post a comment