This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:

chris.jones-gill@ntlworld.com
Domain kisswebdesign.co.uk has exceeded the max emails per hour (100/100 (100%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext7.iad.github.net ([192.30.252.198]:60463 helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by duffman.enixns.com with esmtps (TLSv1:DHE-RSA-AES256-SHA:256)
(Exim 4.82)
(envelope-from noreply@github.com)
id 1Xf4Gx-002gUt-7r
for chris.jones-gill@kisswebdesign.co.uk; Fri, 17 Oct 2014 10:56:35 +0100
Date: Fri, 17 Oct 2014 02:56:33 -0700
From: George Wilson notifications@github.com
Reply-To: joomla/joomla-cms reply@reply.github.com
To: joomla/joomla-cms joomla-cms@noreply.github.com
Message-ID:
Subject: [joomla-cms] Don't access application class var directly (#4744)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5440e7d112dd4_74dd3fa3174a72bc123639f";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: wilsonge
X-GitHub-Recipient: KISS-Web-Design
List-ID: joomla/joomla-cms
List-Archive: https://github.com/joomla/joomla-cms
List-Post: reply@reply.github.com
List-Unsubscribe: unsub+i-46082686-3dffd3640d89504dc07b97f4c02497c576d2ab74-1520943@reply.github.com,
https://github.com/notifications/unsubscribe/1520943__eyJzY29wZSI6Ik5ld3NpZXM6TXV0ZSIsImV4cGlyZXMiOjE3MjkxNTg5OTMsImRhdGEiOnsiaWQiOjQ2MTA0MTY2fX0=--ed09c14ca71f24f57a677efaba9621c220f7852b
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: chris.jones-gill@kisswebdesign.co.uk
X-enixltd-MailScanner-Information: Please contact the ISP for more information
X-enixltd-MailScanner-ID: 1Xf4Gx-002gUt-7r
X-enixltd-MailScanner: Found to be clean
X-enixltd-MailScanner-SpamCheck: not spam, SpamAssassin (not cached,
score=-5.281, required 5, autolearn=not spam, BAYES_00 -1.90,
HTML_IMAGE_ONLY_24 1.62, HTML_MESSAGE 0.00, RCVD_IN_DNSWL_HI -5.00,
SPF_PASS -0.00, URIBL_BLOCKED 0.00)
X-enixltd-MailScanner-From: noreply@github.com
X-Spam-Status: No

----==_mimepart_5440e7d112dd4_74dd3fa3174a72bc123639f
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit

In JResponseJson (the thing that loads the error page when an exception in a component or similar) we can choose to render the messages stored in the application. Currently we get the application object with JFactory::$application instead of JFactory::getApplication() - which is really bad practice

Testing Instructions

Test rendering this error page (throw a random exception in a component high level file (for example the entry point file)) and check everything continues to work as expected
You can merge this Pull Request by running:

git pull https://github.com/wilsonge/joomla-cms patch-24

Or you can view, comment on it, or merge it online at:

#4744

-- Commit Summary --

• Don't access application class var directly

-- File Changes --

M libraries/cms/response/json.php (2)

-- Patch Links --

https://github.com/joomla/joomla-cms/pull/4744.patch
https://github.com/joomla/joomla-cms/pull/4744.diff

Reply to this email directly or view it on GitHub:
#4744

----==_mimepart_5440e7d112dd4_74dd3fa3174a72bc123639f
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit

In JResponseJson (the thing that loads the error page when an exception in a component or similar) we can choose to render the messages stored in the application. Currently we get the application object with JFactory::$application instead of JFactory::getApplication() - which is really bad practice

Testing Instructions

Test rendering this error page (throw a random exception in a component high level file (for example the entry point file)) and check everything continues to work as expected

You can merge this Pull Request by running

  git pull https://github.com/wilsonge/joomla-cms patch-24

Or view, comment on, or merge it at:

  #4744

Commit Summary

• Don't access application class var directly

File Changes

• M libraries/cms/response/json.php (2)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/4744.patch
• https://github.com/joomla/joomla-cms/pull/4744.diff

—
Reply to this email directly or view it on GitHub.

----==_mimepart_5440e7d112dd4_74dd3fa3174a72bc123639f--