Expected result AFTER applying this Pull Request

@krishnagandhicode Do you rally think that makes sense, first message telling that the email could not be sent, and 2nd message telling it was sent?

Or did you maybe mix up the screenshots for the actual and the expected result?

The actual result should describe what happens without this PR, and the expected result should describe what happens with this PR.

Expected result AFTER applying this Pull Request

@krishnagandhicode Do you rally think that makes sense, first message telling that the email could not be sent, and 2nd message telling it was sent?

Or did you maybe mix up the screenshots for the actual and the expected result?

The actual result should describe what happens without this PR, and the expected result should describe what happens with this PR.

The green Message sent banner refers to the internal Joomla's private message being successfully stored in the database(received by receiver). The yellow The email could not be sent banner refers to the external email notification failing

Expected result AFTER applying this Pull Request

@krishnagandhicode Do you rally think that makes sense, first message telling that the email could not be sent, and 2nd message telling it was sent?
Or did you maybe mix up the screenshots for the actual and the expected result?
The actual result should describe what happens without this PR, and the expected result should describe what happens with this PR.

The green Message sent banner refers to the internal Joomla's private message being successfully stored in the database(received by receiver). The yellow The email could not be sent banner refers to the external email notification failing

@krishnagandhicode I see. Still confusing at a first look.

Another thing: Now the reason for the email notification error is only in the log file, e.g. the SMTP error. I'm not sure if that is a good idea. Let see if opinions come in.

The strings need to be modified to be clearer

Perhaps
SMTP Error: The mail could not be sent
The message is available in the users Control Panel

The strings need to be modified to be clearer

Perhaps SMTP Error: The mail could not be sent The message is available in the users Control Panel

I can think of:

Is this okay or we need more (About SMTP) in wanring ?

the problem with that is its still confusing - at least to me

Updated :

Thanks @exlemor for your suggestion to simply make it clear : )

I have tested this item ✅ successfully on c6d5bdd

I have successfully tested this. Even sent a message to a user with multiple access levels - worked!

Thanks @krishnagandhicode!

I have tested this item ✅ successfully on c6d5bdd

RTC

Would it not be less confusing if you only got one message and not two

Sorry but this is not correct as we lose important information.

For example if you disable mail in global configuration and then try and send a message the message BEFORE this PR is clear why the email is not sent

But with this PR we lose that useful information

But with this PR we lose that useful information

That’s true, and it should be looked into again.
@krishnagandhicode could you please have a look at this? Thanks.

I agree. The confusing thing which should be fixed is the "Save failed ..." despite of the message being saved.

But this PR here now causes a loss of important information.

Back to pending.

Thanks - I am looking into it.

Maybe just change the second message from

Save failed with the following error: %s

to

Email could not be sent with the following error: %s The message is available in the Joomla administrator

What about

when mail is disabled :

when mail is enabled but SMTP is not configured perfectly

if needed we can add the Word "Reason" like
The private message was saved, but the email notification could not be sent Reason: The mail function has been disabled by an administrator. (similarly for other case)

Email could not be sent with the following error: %s The message is available in the Joomla administrator

You mean:

and (this needs some clarity ig)

I total agree with the issue that the red UI-error Save failed with the following error: The email could not be sent. gives the wrong signal as the message is stored and delivered to the user as Joomla private message.

I am afraid of the green UI-note Private message is sent. I guess most users will not differentiate between email message and Joomla private message. And they are getting confused is the email sent or not.

1. What about having the two following UI-notes:

• Red Error: Email could not be sent: %s
• Green Notice: The user can view the message in Joomla administrator Private Messages.

2. The success case with the short green Message sent. may say too little? Provide more details?

• Green Notice: The message is sent as email and the user can view the message in Joomla administrator Private Messages.

@brianteeman and @chmst what are you thinking?

@muhme Thanks for looking into this.

• Green Notice: The user can view the message in Joomla administrator Private Messages.

or:
Private Message sent to user's Joomla Administrator Private Messages
Or:
Private Message sent to user's Administrator Private Messages
Or:
Private message successfully saved to the Recipient's Private Inbox

• Green Notice: The message is sent as email and the user can view the message in Joomla administrator Private Messages.

maybe this is bit confusing because It says: message is sent as email and/but can be viewed by user in user's Joomla administrator Private Messages.

Would love to see what others think/say : )

The option shown here #47413 (comment) works for me

Its not perfect but I dont think this is something that can ever be perfect and its better than it is currently

Updated.

I have tested this item ✅ successfully on 65ae849

I have re-tested this successfully. Thanks @krishnagandhicode for the perseverance.

Discussed between the release managers: ✅ We have decided on the current implementation as it eliminates the main source of confusion in the user experience.

Hmm, theoretically this is a change of the language string COM_MESSAGES_ERROR_MAIL_FAILED which can be done only in a new minor release after (change of meaning or change of sprintf parameters, here the latter). So it would need to add a new string with a new key and deprecate the old string and so on.

Or can we be 100% sure that this string is only used by the core?

The rules on changing the meaning of language strings are clear. This would need to be a new strings as the changes are substantially different in meaning

Agreed.
I will keep COM_MESSAGES_ERROR_MAIL_FAILED unchanged to preserve existing meaning, and add a new string maybe COM_MESSAGES_ERROR_MAIL_FAILED_REASON with a %s placeholder for the specific mail error reason used in this PR.

Is that alright ?

Agreed. I will keep COM_MESSAGES_ERROR_MAIL_FAILED unchanged to preserve existing meaning, and add a new string maybe COM_MESSAGES_ERROR_MAIL_FAILED_REASON with a %s placeholder for the specific mail error reason used in this PR.

Is that alright ?

@krishnagandhicode Yes, that looks good.

@krishnagandhicode P.S.: You could also check if the old string COM_MESSAGES_ERROR_MAIL_FAILED is still used somewhere. If that is not the case and it's unused, you can add a comment line above it with a deprecation comment. But if not 100% sure, leave it as it is without a deprecation comment.

I have tested this item ✅ successfully on 8e2670f

@krishnagandhicode P.S.: You could also check if the old string COM_MESSAGES_ERROR_MAIL_FAILED is still used somewhere. If that is not the case and it's unused, you can add a comment line above it with a deprecation comment. But if not 100% sure, leave it as it is without a deprecation comment.

checked for COM_MESSAGES_ERROR_MAIL_FAILED is not used in code anymore so added a deprecation comment.

I have tested this item ✅ successfully on 8e2670f

@dautrich Have you tested with the latest changes (new string COM_MESSAGES_ERROR_MAIL_FAILED_REASON instead of changed string COM_MESSAGES_ERROR_MAIL_FAILED? O'm asking because your test came very quickly after that change, so I think maybe you have tested the previous version.

@exlemor Could you test again with the latest changes? Thanks in advance.

@richard67
I didn't check for the language strings at all. It took me some time to set up my environment. Therefore I assume that I tested before the language strings were changed.

How can I check the language strings?

How can I check the language strings?

@dautrich Just test again with the new prebuilt packages or by applying the PR again. You can check if the administrator/language/en-GB/com_messages.ini file contains the changes shown here: https://github.com/joomla/joomla-cms/pull/47413/changes#diff-dbf9e295e3d9d1a1e10bd7fd303682bb0e519ef90cb8554903bc32d13127a99c

I have tested this item ✅ successfully on 685155b

- Tested with Patchtester, also the optional tests

• Verified that the correct language strings have been applied

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47413.}

I have tested this item ✅ successfully on 685155b

I have successfully restested this. Thanks @krishnagandhicode!

RTC