? Failure
Referenced as Related to: # 4735

User tests: Successful: Unsuccessful:

avatar Nokkaew
Nokkaew
17 Oct 2014

can't save and show error message when without filling the mandatory field "Menu Item Type"

Original Report

Steps to reproduce the issue

  1. Go to Menu->Main Menu-> Add New Menu Item.
  2. Open Add New Menu Item form.
  3. Do not Fill the data in title field and click on save button.
  4. Incorrect validation message is displayed as follow: Error Invalid form

Expected result

Validation message should be user friendly like "invalid field: title"

Actual result

Incorrect validation message is displayed as follow:
Error
Invalid form

System information (as much as possible)

PHP Built On Windows NT 6.2 build 9200
Database Version 5.6.12-log
Database Collation utf8_general_ci
PHP Version 5.4.12
Web Server Apache/2.4.4 (Win64) PHP/5.4.12
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.3.7-dev Development [ Ember ] 01-October-2014 02:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 6.1; rv:32.0) Gecko/20100101 Firefox/32.0screen shot 2014-10-17 at 03 17 42

Additional comments

Validation message should be user friendly.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
1.00

avatar Nokkaew Nokkaew - open - 17 Oct 2014
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 17 Oct 2014
The description was changed
avatar lausianne
lausianne - comment - 17 Oct 2014

@test - 3.3.7-dev
The patch makes no difference for me.

Anyway: I don't find this important, because the form clearly shows where the problem is.



This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4739.

avatar lausianne
lausianne - comment - 17 Oct 2014

Still, I think it would be nice if the error messages in general are a bit more descriptive and perhaps list the issues (all invalid fields) within the error box. It could help with large forms, or when there is an error in a different tab than the selected one.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4739.

avatar lausianne lausianne - test_item - 17 Oct 2014 - Tested unsuccessfully
avatar KISS-Web-Design
KISS-Web-Design - comment - 17 Oct 2014

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:

chris.jones-gill@ntlworld.com
Domain kisswebdesign.co.uk has exceeded the max emails per hour (103/100 (103%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext1.iad.github.net ([192.30.252.192]:41217 helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by duffman.enixns.com with esmtps (TLSv1:DHE-RSA-AES256-SHA:256)
(Exim 4.82)
(envelope-from noreply@github.com)
id 1Xf4IQ-002gz1-5H
for chris.jones-gill@kisswebdesign.co.uk; Fri, 17 Oct 2014 10:58:06 +0100
Date: Fri, 17 Oct 2014 02:58:05 -0700
From: Ralf Longwitz notifications@github.com
Reply-To: joomla/joomla-cms reply@reply.github.com
To: joomla/joomla-cms joomla-cms@noreply.github.com
Message-ID:
In-Reply-To:
References:
Subject: Re: [joomla-cms] Update menutype.php (#4739)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5440e82d59399_6b863f99c05e529c1046119";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: lausianne
X-GitHub-Recipient: KISS-Web-Design
List-ID: joomla/joomla-cms
List-Archive: https://github.com/joomla/joomla-cms
List-Post: reply@reply.github.com
List-Unsubscribe: unsub+i-46081002-173375f338ed70185dc17a1f950ffc010b0f524b-1520943@reply.github.com,
https://github.com/notifications/unsubscribe/1520943__eyJzY29wZSI6Ik5ld3NpZXM6TXV0ZSIsImV4cGlyZXMiOjE3MjkxNTkwODUsImRhdGEiOnsiaWQiOjQ2MTAyMzA1fX0=--e1b5fa227274d1d2faa527960f2b063c17ea0e65
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: chris.jones-gill@kisswebdesign.co.uk
X-enixltd-MailScanner-Information: Please contact the ISP for more information
X-enixltd-MailScanner-ID: 1Xf4IQ-002gz1-5H
X-enixltd-MailScanner: Found to be clean
X-enixltd-MailScanner-SpamCheck: not spam, SpamAssassin (not cached,
score=-5.807, required 5, autolearn=not spam, BAYES_00 -1.90,
HTML_IMAGE_ONLY_16 1.09, HTML_MESSAGE 0.00, RCVD_IN_DNSWL_HI -5.00,
SPF_PASS -0.00, URIBL_BLOCKED 0.00)
X-enixltd-MailScanner-From: noreply@github.com
X-Spam-Status: No

----==_mimepart_5440e82d59399_6b863f99c05e529c1046119
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit

Still, I think it would be nice if the error messages in general are a bit more descriptive and perhaps list the issues (all invalid fields) within the error box. It could help with large forms, or when there is an error in a different tab than the selected one.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4739.


Reply to this email directly or view it on GitHub:
#4739 (comment)
----==_mimepart_5440e82d59399_6b863f99c05e529c1046119
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit

Still, I think it would be nice if the error messages in general are a bit more descriptive and perhaps list the issues (all invalid fields) within the error box. It could help with large forms, or when there is an error in a different tab than the selected one.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4739.


Reply to this email directly or view it on GitHub.

----==_mimepart_5440e82d59399_6b863f99c05e529c1046119--

avatar Nokkaew
Nokkaew - comment - 17 Oct 2014

I'm terribly sorry. Indeed I wanted to fix for this issue
http://issues.joomla.org/tracker/joomla-cms/4732

avatar brianteeman brianteeman - change - 17 Oct 2014
Category Administration
avatar pete-rossetti
pete-rossetti - comment - 17 Oct 2014

#4751 has a successful patch for this changes it to Invalid Menu Title

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4739.

avatar zero-24 zero-24 - change - 17 Oct 2014
Title
Update menutype.php
Can't save and show error message when without filling the mandatory field "Menu Item Type"
avatar zero-24
zero-24 - comment - 17 Oct 2014

I have adjust the titel a bit

avatar revers28
revers28 - comment - 17 Oct 2014

@test successfully tested patch #4751 for this issue. Browser chrome.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4739.

avatar revers28 revers28 - test_item - 17 Oct 2014 - Tested successfully
avatar larapetersen
larapetersen - comment - 17 Oct 2014

@test could reproduce the issue (Chrome), but the patch doesn't do anything.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4739.

avatar larapetersen larapetersen - test_item - 17 Oct 2014 - Tested unsuccessfully
avatar larapetersen
larapetersen - comment - 17 Oct 2014

Shouldn't this one be closed?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4739.

avatar revers28 revers28 - test_item - 17 Oct 2014 - Tested unsuccessfully
avatar revers28
revers28 - comment - 17 Oct 2014

@test patch #4739 does not solve this problem!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4739.

avatar jissues-bot
jissues-bot - comment - 8 Nov 2014

Set to "closed" on behalf of @roland-d by The JTracker Application at issues.joomla.org/joomla-cms/4739

avatar roland-d roland-d - change - 8 Nov 2014
Status Pending Closed
avatar jissues-bot jissues-bot - close - 8 Nov 2014
avatar roland-d
roland-d - comment - 8 Nov 2014

Closed because the issue has been fixed in PR #4517

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4739.

avatar jissues-bot jissues-bot - change - 8 Nov 2014
Closed_Date 0000-00-00 00:00:00 2014-11-08 03:32:54

Add a Comment

Login with GitHub to post a comment