NPM Resource Changed bug UI/UX PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar mehkanarshad
mehkanarshad
14 Mar 2026

Pull Request resolves #45012 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Adjusted SCSS for proper spacing and alignment which Improved responsiveness on smaller screens.

Testing Instructions

Go to Joomla admin → Media Manager. Verify breadcrumb and media browser alignment on screen smaller than 1200px.

Actual result BEFORE applying this Pull Request

Inconsistent spacing, especially on smaller screens.
image

Expected result AFTER applying this Pull Request

Spacing consistent across all screen sizes.
image

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar mehkanarshad mehkanarshad - open - 14 Mar 2026
avatar mehkanarshad mehkanarshad - change - 14 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2026
Category Repository NPM Change
avatar mehkanarshad mehkanarshad - change - 14 Mar 2026
The description was changed
avatar mehkanarshad mehkanarshad - edited - 14 Mar 2026
avatar brianteeman
brianteeman - comment - 14 Mar 2026

to make it easier for testers to evaluate the changes please include some before and after screenshots

avatar mehkanarshad mehkanarshad - change - 14 Mar 2026
The description was changed
avatar mehkanarshad mehkanarshad - edited - 14 Mar 2026
avatar richard67 richard67 - change - 14 Mar 2026
Title
Adjusted media manager SCSS
[5.4] Adjusted media manager SCSS
avatar richard67 richard67 - edited - 14 Mar 2026
avatar exlemor
exlemor - comment - 15 Mar 2026

Hi @mehkanarshad, I can't reproduce the AFTER condition, I am getting the same results as BEFORE at 1181px wide ;(


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47387.

avatar brianteeman brianteeman - test_item - 15 Mar 2026 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 15 Mar 2026

I have tested this item 🔴 unsuccessfully on 9a3f1ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47387.

avatar brianteeman
brianteeman - comment - 15 Mar 2026
image
avatar mehkanarshad mehkanarshad - change - 15 Mar 2026
Labels Added: NPM Resource Changed UI/UX PR-5.4-dev
avatar brianteeman brianteeman - test_item - 15 Mar 2026 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 15 Mar 2026

I have tested this item 🔴 unsuccessfully on 9a3f1ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47387.

avatar mehkanarshad
mehkanarshad - comment - 15 Mar 2026

Hi @exlemor @brianteeman ,

I’ve just pushed an updated commit with further SCSS adjustments. Hopefully, this resolves the spacing and alignment issue at all screen widths.

Please let me know if it works as expected.

avatar brianteeman
brianteeman - comment - 15 Mar 2026

Are you actually testing what you submit or are you just guessing?

image
avatar mehkanarshad
mehkanarshad - comment - 17 Mar 2026

I didn’t test it properly the first time. The second time, I adjusted it intentionally because I thought the space above was too small for the media files. I’ve now changed it the other way around.

avatar richard67
richard67 - comment - 17 Mar 2026

@mehkanarshad Please fix the code style errors reported here: https://github.com/joomla/joomla-cms/actions/runs/23184461499/job/67369094630?pr=47387 . Thanks in advance.

avatar brianteeman brianteeman - test_item - 17 Mar 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 Mar 2026

I have tested this item ✅ successfully on a40affe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47387.

avatar brianteeman
brianteeman - comment - 17 Mar 2026

i'm not a css expert but this appears to be ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47387.

avatar krishnagandhicode krishnagandhicode - test_item - 20 Mar 2026 - Tested successfully
avatar krishnagandhicode
krishnagandhicode - comment - 20 Mar 2026

I have tested this item ✅ successfully on a40affe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47387.

avatar richard67 richard67 - change - 20 Mar 2026
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 20 Mar 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47387.

avatar Fedik
Fedik - comment - 20 Mar 2026

Note: it is partial fix of #45012
The issue with large folders list in "navigation" is still actual.

avatar Fedik
Fedik - comment - 20 Mar 2026

It does not fixes Table view,

And it pretty strange/tight on Tablet now:
Screenshot 2026-03-20_18-23-26

avatar richard67
richard67 - comment - 20 Mar 2026

@Fedik Shall we remove RTC and request changes? Or shall we only remove the reference to the issue because this PR only solved it partly so that the issue will not be closed automatically by GitHub when that PR will be merged?

avatar Fedik
Fedik - comment - 20 Mar 2026

I would remove RTC. And ask for changes.

We still can fix Media query here, but it is need to test across all screen sizes (laptop, tablet, mobile) not only mentioned in the issue. To be sure nothing is broken after the changes.

Also the Table view need to be addressed.

avatar richard67 richard67 - change - 20 Mar 2026
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 20 Mar 2026

Back to pending due to previous comments.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47387.

avatar richard67
richard67 - comment - 20 Mar 2026

@mehkanarshad Could you check @Fedik 's previous three comments and let us know if you can update your PR fix the issue completely?

avatar Fedik
Fedik - comment - 20 Mar 2026

@mehkanarshad you can skip the "The folders navigation" it is not something that can be easily fixed as part of bug fix. However you still can adjust the media query to make it looks good on all major screen sizes.

avatar mehkanarshad mehkanarshad - change - 23 Mar 2026
Labels Added: Updates Requested bug
avatar mehkanarshad
mehkanarshad - comment - 23 Mar 2026

Hey Fedik,

I reviewed your feedback and adjusted the layout so the flex wrapping kicks in at a point where the folders don’t feel cramped and the sidebar doesn’t expand too much. I also updated the table to allow horizontal scrolling.

This should improve responsiveness across the main screen sizes—let me know if anything still feels off.

avatar muhme
muhme - comment - 27 Mar 2026

@Fedik Could you please review the changes and approve them? We could then remove the “Updates requested” label and the PR could be tested again and across the various screen sizes.

avatar Fedik
Fedik - comment - 27 Mar 2026

It looks good now

avatar muhme
muhme - comment - 27 Mar 2026

@brianteeman and @krishnagandhicode may I ask you for testing this PR again?

avatar exlemor
exlemor - comment - 27 Mar 2026

@mehkanarshad - It looks good for screen smaller on laptop under 1200px now and when I tested iPad was fine but when I tested iPhone/mobile phones sizes... it could be me but the bottom section doesn't work, the file folders/file icons are too small, squashed - I'd expect them to be vertically max 2 columns....

It seems to be caused by media.manager.min.css having the entry:

.media-browser-items.media-browser-items-md {grid-template-columns: repeat(auto-fill,minmax(18%,1fr));}

while

.media-browser-items.media-browser-items-md {grid-template-columns: repeat(auto-fill,minmax(35%,1fr));}

looks a lot easier to read...

It looks like this now:

ScreenFloat Shot of Safari on 2026-03-27 at 23-00-37

instead of being able to look like this (easier to read):

ScreenFloat Shot of Finder on 2026-03-27 at 23-46-50
avatar mehkanarshad mehkanarshad - change - 30 Mar 2026
Labels Removed: Updates Requested
avatar mehkanarshad
mehkanarshad - comment - 30 Mar 2026

@exlemor
I’ve updated the grid to use 2 columns on smaller screens only (≤576px), which keeps the items readable without affecting tablet layouts.

Add a Comment

Login with GitHub to post a comment