PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
13 Mar 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

While integrating Mail Template Layout for my extensions, I noticed a small issue in MailTemplate.

The FileLayout::render method only defines one parameter, but two arguments are passed when calling the method in MailTemplate. This is incorrect and should be fixed.

This code also appears in earlier Joomla versions. However, PHP does not throw an error, so I am submitting this PR for 6.1-dev instead of 5.4-dev.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works. But code has invalid extra arguement passed

Expected result AFTER applying this Pull Request

Works.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 13 Mar 2026
avatar joomdonation joomdonation - change - 13 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2026
Category Libraries
avatar tecpromotion tecpromotion - change - 13 Mar 2026
Title
Remove invalid second argument from LayoutFile::render() call
[6.1] Remove invalid second argument from LayoutFile::render() call
avatar tecpromotion tecpromotion - edited - 13 Mar 2026
avatar tecpromotion tecpromotion - change - 13 Mar 2026
Labels Added: PR-6.1-dev
avatar tecpromotion
tecpromotion - comment - 13 Mar 2026

Thanks @joomdonation

avatar tecpromotion tecpromotion - change - 13 Mar 2026
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-03-13 08:27:54
Closed_By tecpromotion
avatar tecpromotion tecpromotion - close - 13 Mar 2026
avatar tecpromotion tecpromotion - merge - 13 Mar 2026

Add a Comment

Login with GitHub to post a comment