PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
9 Mar 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

#45818 Extend Events related deprecation till Joomla 7.
This pr updates the code comments to reflect that changed deprecation

Testing Instructions

code review only

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 9 Mar 2026
avatar brianteeman brianteeman - change - 9 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Mar 2026
Category Libraries Front End Plugins
avatar laoneo
laoneo - comment - 9 Mar 2026

Can you change it to explicit 7.0 (or just 7) as we can't remove it in another version than 7.0.0. The .x assumes in any version of the 7 series.

avatar brianteeman
brianteeman - comment - 9 Mar 2026

@laoneo the actual deprecation notice is @deprecated 4.3 will be removed in 7.0 and i just changed the existing comment from 5 to 7 but i can of course change it to 7.0 in the comment

9a87187 9 Mar 2026 avatar brianteeman 7.0
avatar brianteeman brianteeman - change - 9 Mar 2026
Labels Added: PR-6.0-dev
f77433d 9 Mar 2026 avatar brianteeman 7.0
4615b89 9 Mar 2026 avatar brianteeman 7.0
avatar laoneo
laoneo - comment - 9 Mar 2026

Then its more clear. Thanks

avatar richard67
richard67 - comment - 9 Mar 2026

Why is this PR made for the 6.0-dev branch?

avatar brianteeman
brianteeman - comment - 9 Mar 2026

because i have absolutely no idea what branch it should be against - you said there wouldnt be another 5.4 release so i guessed it should be for 6.0. or did you say there wouldnt be another 6.0 release. With so many branches its very confusing

avatar richard67
richard67 - comment - 9 Mar 2026

because i have absolutely no idea what branch it should be against - you said there wouldnt be another 5.4 release so i guessed it should be for 6.0. or did you say there wouldnt be another 6.0 release. With so many branches its very confusing

@i think you mixed it up. I said there might be no 6.0.4 as there is 6.1.0 stable soon. But of course there will be 5.4 releases. 5.4 is in bug fix mode until October when 6.2.0 comes, and then one more year 5.4 security fix mode.

As the referenced PR was merged into 5.4, I would also expect this one to be for 5.4.

avatar brianteeman
brianteeman - comment - 9 Mar 2026

ok i will rebase it to j5

avatar brianteeman brianteeman - close - 9 Mar 2026
avatar brianteeman
brianteeman - comment - 9 Mar 2026

closing - will reopen for 5

avatar brianteeman brianteeman - change - 9 Mar 2026
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2026-03-09 13:57:48
Closed_By brianteeman
avatar joomla-cms-bot joomla-cms-bot - change - 9 Mar 2026
Category Libraries Front End Plugins Repository Administration com_admin SQL
avatar brianteeman brianteeman - change - 9 Mar 2026
Status Closed New
Closed_Date 2026-03-09 13:57:48
Closed_By brianteeman
Labels Added: PR-5.4-dev
avatar brianteeman brianteeman - change - 9 Mar 2026
Status New Pending
avatar brianteeman
brianteeman - comment - 9 Mar 2026

@richard67 I have re=opened this for 6.0 as some of the comments relate to another PR #46367 which was for 6.0

Otherwise I would need to split this into two PR for 5.4 and 6.0 and for just a comment update it seems unnecessary

avatar laoneo
laoneo - comment - 9 Mar 2026

We changed to the target versions to 7 only in the 6 branch (#46367). So I would do this only in 6 as well.

avatar richard67
richard67 - comment - 9 Mar 2026

We changed to the target versions to 7 only in the 6 branch (#46367). So I would do this only in 6 as well.

I see. I was not aware of that other PR.

avatar Bodge-IT Bodge-IT - change - 9 Mar 2026
Labels Removed: PR-5.4-dev
avatar joomla-cms-bot joomla-cms-bot - change - 9 Mar 2026
Category Repository Administration com_admin SQL Libraries Front End Plugins
avatar Bodge-IT Bodge-IT - change - 9 Mar 2026
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-03-09 18:52:13
Closed_By Bodge-IT
avatar Bodge-IT Bodge-IT - close - 9 Mar 2026
avatar Bodge-IT Bodge-IT - merge - 9 Mar 2026
avatar Bodge-IT
Bodge-IT - comment - 9 Mar 2026

Thanks @brian and for reviews

avatar richard67
richard67 - comment - 9 Mar 2026

Thanks @brian and for reviews

@Bodge-IT You pinged the wrong Brian.

Add a Comment

Login with GitHub to post a comment