[#47331] - [6.2] Super User only modules
- Pending
- Medium
- Build: 6.1-dev
- # 47331
- Diff
- brianteeman:superuser_modules
User tests: Successful: Unsuccessful:
Pull Request resolves #46896 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
As reported in the issue it is confusing for users who are not super users that they can create an admin module such as Latest User Actions but then do not see the module on their site.
This is because the module is hard coded to only be displayed to super users and ignores the setting in the View Access select for the module.
This PR is an alternative to #47295 which took the approach of hiding the module from the select new module page but did not prevent a non super-user from being able to edit/delete an existing module of this type.
This PR takes a different approach - instead of preventing a non super user being able to create (or even edit) a module with this restriction we simply add text information to inform the user that the module they are creating/editing is only visible to super users.
I believe this is the better approach as it doesn't require any significant code change or change in the user experience for creating admin modules AND we now tell all users that this specific module is only visible to Super Users. (Without this PR they will never know about the restriction as its buried in the code and doesnt use the normal View Access setting)
This PR should be considered a proof of concept so I only added the extra information to ONE of the modules that has this restriction. If accepted then I would update the PR to do the same for the other Super User only modules.
For this reason the language string used is in COM_MODULES.INI and not in MOD_LATESTSACTIONS.INI so that we can re-use the same string in all modules.
Testing Instructions
This is only a visual change in the admin UI and is the same for all users
Apply PR and then either open an existing Lastes Actions module or create a new one
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Additional Comments for Maintainers
The original issue was opened against 5.4 but I dont consider it a bug
Additionally as its a new language string we can't do that in a patch release
Obviously I would like to see this merged as soon as possible but if it is considered to be too late for 6.1 then it should be pushed to 6.2
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Modules |
I have tested this item ✅ successfully on 129cf4e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47331.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47331.
PLEASE remove RTC
This PR should be considered a proof of concept so I only added the extra information to ONE of the modules that has this restriction. If accepted then I would update the PR to do the same for the other Super User only modules.
I would update the PR to do the same for the other Super User only modules
Dear @brianteeman, yes, we like to use it. Could you please add the other modules? And regarding the current note, as for adding the module it is visible, could we adopt the message to make it more clear? e.g.
- Note: This module is restricted to Super Users and will not be visible to other users after creation.
or e.g. - You can create this module, but once created it is only visible and usable by Super Users.
No I will not change the text. IT is correct as I proposed and your suggestion is overly complex and doesnt make sense when it is read on an existing module
AND please remove the RTC again until the additional modules have been added
| Labels |
Added:
RTC
Language Change
PR-6.1-dev
|
||
i have added mod_privacy_status and mod_privacy_dashboard
i dont believe any other modules have this problem (mod_messages was incorrectly identified before)
ain’t this message (This module is only visible to Super user) is confusing because after reading if the user logs in as admin these modules are STILL VISIBLE(While creation and the exiting ones which are even editable ) ?
the message refers to the display of the module not the config of the module
| Status | Ready to Commit | ⇒ | Pending |
Return to Pending as more modules are added
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47331.
Just added the "Updates requested" label as updates were requested for the text :-)
The current text is correct. The suggested text is not as already explained
This pull request has been automatically rebased to 6.2-dev.
| Title |
|
||||||
I have tested this item ✅ successfully on 129cf4e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47331.