PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar adarshdubey03
adarshdubey03
6 Mar 2026

Pull Request resolves #47298 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Fixes a missing space before the page class suffix in the article layout.
Previously the value of pageclass_sfx was concatenated directly with the item-page class, producing invalid class names such as item-pagepage-class.
The fix ensures the suffix is trimmed and preceded by a space when present, so CSS classes remain properly separated.

Testing Instructions

Create a Category Blog menu item.
In the Page Display tab, set Page Class to page-class.
Create an article within the same category.
Open the article via the blog menu item.
Inspect the main article container in the browser dev tools.

Actual result BEFORE applying this Pull Request

The class names are concatenated without a space:
com-content-article item-pagepage-class

Expected result AFTER applying this Pull Request

The page class suffix is correctly separated:
com-content-article item-page page-class

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar adarshdubey03 adarshdubey03 - open - 6 Mar 2026
avatar adarshdubey03 adarshdubey03 - change - 6 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Mar 2026
Category Front End com_content
avatar brianteeman
brianteeman - comment - 6 Mar 2026

the space is not missing it is by design that its this way

avatar HLeithner HLeithner - change - 6 Mar 2026
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2026-03-06 13:23:26
Closed_By HLeithner
Labels Added: PR-6.1-dev
avatar HLeithner HLeithner - close - 6 Mar 2026
avatar adarshdubey03
adarshdubey03 - comment - 6 Mar 2026

Thanks for the clarification.

I interpreted it as a bug because when the suffix is entered without a leading space (e.g. page-class), the resulting class becomes item-pagepage-class, which merges the class names. I see now that the current behavior is intentional and expects the space to be included in the suffix.

Thanks for explaining , I’ll close the PR.

avatar HLeithner
HLeithner - comment - 6 Mar 2026

as @brianteeman said, that's expected behavior

avatar brianteeman
brianteeman - comment - 6 Mar 2026

your pr would of course broken every existing site that was relying on it being a new class

avatar adarshdubey03
adarshdubey03 - comment - 6 Mar 2026

Understood, thanks for explaining the compatibility concern.

Add a Comment

Login with GitHub to post a comment