[#47310] - [6.1] Improve Multilanguage::getSiteHomePages() - fix for CLI app
- Closed
- 6 Mar 2026
- Medium
- Build: 6.1-dev
- # 47310
- Diff
- Denitz:patch-8
User tests: Successful: Unsuccessful:
Pull Request resolves issue with merged #41507.
Summary of Changes
Keep old logic for CliApplication because it doesn't have getMenu() method defined in CMSWebApplicationInterface.
Testing Instructions
call Joomla\CMS\Language\Multilanguage::getSiteHomePages() in CLI command.
Actual result BEFORE applying this Pull Request
Error
Expected result AFTER applying this Pull Request
No error
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-6.1-dev
|
||
I think revert is the better way for the moment and deprecate the method and remove it in 8.0.
I checked the usages and all of them can directly or indirectly access the $app->getMenu().
I'm closing this please see #41507 (comment)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-03-06 09:03:58 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
Release Blocker
bug
|
||
Thanks, but that's not a real solution. Now we have the same code twice and no long term solution. Any other idea? And a long time plan? maybe deprecated the support of applications which don't support the "menu"?