User tests: Successful: Unsuccessful:
Pull Request resolves #46912 .
This PR fixes an inconsistency where language overrides were not applied to custom field and filed group titles in the adminstrator list view.
When the field or field group titles was stored as a language constant (eg:- 'CUSTOM_FIELD_TEST_TITLE') and also language override existed. In the administrator Fields and Field Groups list views, the raw constant was rendered instead of translated text.
BEFORE: title was displayed instead of language constant
AFTER: language overrides are applied successfully.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_fields |
| Labels |
Added:
PR-5.4-dev
|
||
| Title |
|
||||||
Hii @brianteeman
I have now verified that group title is now correctly translated in the Field list (including the Field Group column ) and in the Field group list view as mentioned in the issue #46912
But the group name is still not translated in :-
Field edit form (group dropdown )
the Batch → Move/Copy group dropdown
Before proceeding further could you please point me to the preferred layer/file where this should be handled ? Should this be fixed in the form field class or there is any preferred layer/files ?
Hii @brianteeman
The remaining untranslated group titles were coming from two diffrent sources FieldgroupsField and FieldsModel::getGroups() , both were returning raw titles without passing through Text::_().
I have now updated. Here are the screenshots
@bembelimen @richard67 , Please review
Sorry but you have not addressed all areas. In the screenshots below you will see the language overrides I have created
And here you can see where it does and does not work