RTC NPM Resource Changed bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Feb 2026

Pull Request resolves #47225 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

#46328 introduced a checkmark to indicate selected items. Unfortunately the css wasnt quite correct as there should not be a background set else it doesnt look great on hover

Testing Instructions

In any choices select such as the category filer in the article manager. Select one or more items and then check the dropdown again.

As this changes the scss you will need to either npm run build:css or use a prebuilt package

Actual result BEFORE applying this Pull Request

Light Mode

image

Dark Mode

image

Expected result AFTER applying this Pull Request

Light Mode

image

Dark Mode

image

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 25 Feb 2026
avatar brianteeman brianteeman - change - 25 Feb 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2026
Category Repository NPM Change
avatar brianteeman brianteeman - change - 25 Feb 2026
Labels Added: NPM Resource Changed PR-5.4-dev
avatar brianteeman
brianteeman - comment - 25 Feb 2026

updating branch to see if it fix the ci error

avatar coolcat-creations coolcat-creations - test_item - 25 Feb 2026 - Tested successfully
avatar coolcat-creations
coolcat-creations - comment - 25 Feb 2026

I have tested this item ✅ successfully on cd0adc1

thank you, looks better now IMO


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47226.

avatar richard67 richard67 - alter_testresult - 26 Feb 2026 - coolcat-creations: Tested successfully
avatar tecpromotion tecpromotion - test_item - 27 Feb 2026 - Tested successfully
avatar tecpromotion
tecpromotion - comment - 27 Feb 2026

I have tested this item ✅ successfully on 8270034


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47226.

avatar tecpromotion tecpromotion - change - 27 Feb 2026
Status Pending Ready to Commit
avatar tecpromotion
tecpromotion - comment - 27 Feb 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47226.

avatar richard67
richard67 - comment - 27 Feb 2026

@coolcat-creations @tecpromotion According to this comment (and the 2 after it), this PR could cause problems in 5.4-dev because another PR #47207 for these problems was merged only in 6.1-dev: #47225 (comment)

So either we move this here to 6.1-dev, too, or we make a new PR to backport the other PR #47207 to 5.4-dev.

Update: It seems the other problems (margin) are different on 5.4-dev and 6.1-dev, see this comment #47207 (comment)

Would be nice if someone could make a PR for 5.4-dev for that.

avatar richard67 richard67 - change - 27 Feb 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-02-27 11:08:22
Closed_By richard67
Labels Added: RTC bug
avatar richard67 richard67 - close - 27 Feb 2026
avatar richard67 richard67 - merge - 27 Feb 2026
avatar richard67
richard67 - comment - 27 Feb 2026

Thanks @brianteeman for this PR, and @coolcat-creations and @tecpromotion for testing.

Add a Comment

Login with GitHub to post a comment