User tests: Successful: Unsuccessful:
Pull Request resolves #47225 .
#46328 introduced a checkmark to indicate selected items. Unfortunately the css wasnt quite correct as there should not be a background set else it doesnt look great on hover
In any choices select such as the category filer in the article manager. Select one or more items and then check the dropdown again.
As this changes the scss you will need to either npm run build:css or use a prebuilt package
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.4-dev
|
||
I have tested this item ✅ successfully on cd0adc1
thank you, looks better now IMO
I have tested this item ✅ successfully on 8270034
| Status | Pending | ⇒ | Ready to Commit |
RTC
@coolcat-creations @tecpromotion According to this comment (and the 2 after it), this PR could cause problems in 5.4-dev because another PR #47207 for these problems was merged only in 6.1-dev: #47225 (comment)
So either we move this here to 6.1-dev, too, or we make a new PR to backport the other PR #47207 to 5.4-dev.
Update: It seems the other problems (margin) are different on 5.4-dev and 6.1-dev, see this comment #47207 (comment)
Would be nice if someone could make a PR for 5.4-dev for that.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-02-27 11:08:22 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
RTC
bug
|
||
Thanks @brianteeman for this PR, and @coolcat-creations and @tecpromotion for testing.
updating branch to see if it fix the ci error