bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
24 Feb 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Fix deprecated warning in mod_popular when publish_up is null (php 8.4)

Testing Instructions

Code inspect.
Or set error-reporting to maximum, set in one of the popular articles the publish_up date to NULL (sql).

Actual result BEFORE applying this Pull Request

Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated

Expected result AFTER applying this Pull Request

No Warning.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar chmst chmst - open - 24 Feb 2026
avatar chmst chmst - change - 24 Feb 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2026
Category Modules Administration
avatar ceford
ceford - comment - 10 Mar 2026

Not sure about this. Without the patch I get this:

Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /Users/ceford/Sites/joomla-cms5/libraries/src/Date/Date.php on line 126
2026-03-10 

But with the patch I get this:

Warning: Undefined property: stdClass::$created in /Users/ceford/Sites/joomla-cms5/administrator/modules/mod_popular/tmpl/default.php on line 51

Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /Users/ceford/Sites/joomla-cms5/libraries/src/Date/Date.php on line 126

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47213.
avatar brianteeman
brianteeman - comment - 13 Mar 2026

I get exactly the same as @ceford

avatar brianteeman brianteeman - test_item - 13 Mar 2026 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 13 Mar 2026

I have tested this item 🔴 unsuccessfully on 3a15ab5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47213.

avatar chmst
chmst - comment - 13 Mar 2026

I forgot to commit the helper file. Apologies.

avatar chmst chmst - change - 13 Mar 2026
Labels Added: bug PR-5.4-dev
avatar chmst chmst - close - 14 Mar 2026
avatar chmst
chmst - comment - 14 Mar 2026

Closing this to avoid conflicts with #46605, where the helper file was modified.

avatar chmst chmst - change - 14 Mar 2026
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2026-03-14 08:56:55
Closed_By chmst
avatar brianteeman
brianteeman - comment - 17 Mar 2026

@chmst as that PR was for 6.1 does that mean we're not fixing the bug for 5.4

Add a Comment

Login with GitHub to post a comment