[#4721] - Fix issue #4702
- Closed
- 17 Oct 2014
- Medium
- Build: staging
- # 4721
- Diff
- joomdonation:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR fix the issue #4702 reported by @dkanchev. Please see #4702 to understand the actual issue (he explained it very well).
How to test
Apply this PR .
Go to Extensions -> Module Manager, try to duplicate a module several times.
Makes sure the title of the module is generated properly as explained in the Expected result of issue report (at the moment, the title of the duplicated module is always appended by (2) and it causes the confusing when you duplicate the same module several times)
My opinion is that every duplicated module should have a new unique name and not the same name as another module. This helps people to differentiate the modules - users do not care about unique IDs - they use module names.
Votes
jissues-bot
- | Labels |
Added:
?
|
||
nicksavov
- | Labels |
Added:
?
|
||
| Rel_Number | ⇒ | 4701 | |
| Relation Type | ⇒ | Related to |
| Rel_Number | 4701 | ⇒ | 4702 |
lunalars
- 
@test I tested the patch and it seems to be working. When I duplicate a module and then try to duplicate it again, the name is now unique:
http://awesomescreenshot.com/0593ocuaf0
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4721.
Thanks @seakson and @dimitargsg for testing the PR.
@@dimitargsg I really like the way you tested it and showing the result. It proves that your understand the issue and the expected very well. Nice test :).
Multiple good tests thanks setting to rtc
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4721.
| Status | Pending | ⇒ | Ready to Commit |
Thanks @brianteeman. Please see my comment on the issue #4702 (comment) . Need your advice to make a new PR.
infograf768
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-17 07:10:53 |
I am test. It work good. title module is not duplicate