Pull Request resolves #19652

• I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Changed the method populateState() in itemModel.php to setUserState ( menu type, client id) only when a new menu item is being created.
What this does is that when we edit a menu item and click on 'save and close' we will be redirected to the list view of menu items with the original menu type filter instead of it being set to the menu type of the article that was edited.
But when we create a new menu item the previous functionality is preserved.

Testing Instructions

[ DO NOT test just yet as ideal behavior when the menu type of a previously existing item is changed while editing is ambiguous ( need help of maintainer) ]

Case 1: Editing

1. go to list view of 'all menu items', do not set any filters
2. select an article to edit
3. save and close

Case 2: Creating

1. create a new menu item
2. save and close

Case 3: Editing ( change menu type )

1. go to list view of 'all menu items', do not set any filters
2. select an article to edit
3. change its menu type.
4. save and close

Actual result BEFORE applying this Pull Request

get redirected to list view of menu items with the menu type filter set to the menu type of the article edited / created.

Expected result AFTER applying this Pull Request

Case 1:
get redirected to list view of menu items with the original filter ( ie no filter ).

Case 2:
same as before

Case 3:
same as before

Link to documentations

Please select:

• Documentation link for guide.joomla.org:

• No documentation changes for guide.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed