? Error

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
16 Oct 2014

Internal to the class, the getTable method is not used in a static context. In an effort to improve code structure, this method should no longer be declared static. Since it is possible the method could be called by an external source statically, we can't make the change now as doing so would throw a warning about calling a non-static method in a static manner. Therefore, for awareness purposes, I've added a note which indicates this change should occur in 4.0.

Note there isn't anything testable about this PR but it does serve as a documentation reference.

avatar mbabker mbabker - open - 16 Oct 2014
avatar jissues-bot jissues-bot - change - 16 Oct 2014
Labels Added: ?
avatar infograf768 infograf768 - change - 16 Oct 2014
Milestone Added:
avatar infograf768 infograf768 - close - 16 Oct 2014
avatar infograf768 infograf768 - reference | 1782d26 - 16 Oct 14
avatar infograf768 infograf768 - merge - 16 Oct 2014
avatar infograf768 infograf768 - close - 16 Oct 2014
avatar infograf768 infograf768 - change - 16 Oct 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-16 13:54:08
avatar mbabker mbabker - head_ref_deleted - 16 Oct 2014

Add a Comment

Login with GitHub to post a comment