[#46933] - [5.4] fix undefined array key warnings in workflow permissionns
- Fixed in Code Base
- 11 Mar 2026
- Medium
- Build: 5.4-dev
- # 46933
- Diff
- krishnagandhicode:fix-workflow-undefined-keys
User tests: Successful: Unsuccessful:
Pull Request resolves #46885
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
fixes the undefined array key warnings for "value" and "from_stage_id" that show up when a usr is denied Execute Transition permissions in workflows. The code was assuming these keys always exist, but they are missing for restricted users. I added fallback checks (?? 0) in Htmlview.php and Contenthelper.php to stop the errorrs.
Testing Instructions
- Install Blog Sample Data
- allow workflows (by content -> article -> options -> intigration -> enable workflows)
- now content -> workflow -> basic-workflow -> pemissions -> administrator -> Execute Transition : denied.
4. create a user with admin only acces.(if not already)
5. login as admin
6. go to content -> articles
Create Admin user with just administrator group
Set the new workflow for category "Uncategorised".
Login as admin
Open articles
Before applying patch :
20260224-0926-49.7968238.mp4
After Applying Patch:
no error messages.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Title |
|
||||||
Yes i missed it, only was locking for code as such , sorry. Will test it
I have tested this item ✅ successfully on c0cb616
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46933.
I have tested this item ✅ successfully on c0cb616
I was able to successfully test this @krishnagandhicode - Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46933.
| Labels |
Added:
bug
PR-5.4-dev
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46933.
✅ Final test before merge using JBT
- Seen error before
- Applied PR with Patch Tester
- Error messages are gone
- Still no direct workflow stage changes for the disabled workflow
- Direct changes to the workflow stage continue to work for other activated workflows
Thank you @krishnagandhicode for your next contribution. Thank you @ThomasFinnern and @exlemor for testing.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-03-11 07:49:03 |
| Closed_By | ⇒ | muhme | |
| Labels |
Added:
RTC
|
||
actually I moved the casting up to line 211:
$transitionValue = (int) ($transition['value'] ?? 0);maybe you missed it in the diff?