[#46929] - [5.4] Expose filename on autoupdate prepare step
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 46929
- Diff
- SniperSister:54-autoupdate-filename
User tests: Successful: Unsuccessful:
Pull Request resolves #46495
Summary of Changes
This PR adds the package filename to the update preparation response - this allows the update server to clean up the archive after the update has been performed.
The filename was already returned by the model but not exposed in the JSON response see
https://github.com/SniperSister/joomla-cms/blame/7be13cd461e412f57bb9dcf97248d758a1a9ce37/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php#L569
vs the list of fields in the now updated view.
Testing Instructions
Core review
Actual result BEFORE applying this Pull Request
- Field missing
Expected result AFTER applying this Pull Request
- Field present
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Title |
|
||||||
I have tested this item ✅ successfully on 7be13cd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46929.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46929.
| Labels |
Added:
RTC
|
||
I have tested this item ✅ successfully on 7be13cd
Code review: The filename is returned by the model, but without this PR it is missing in the JSON response. With this PR it is added to the response in the JsonapiView.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46929.