[#46908] - [6.0] Fix PHP warnings when opening Page Break modal
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 46908
- Diff
- sathwikre:fix-pagebreak-null-item
User tests: Successful: Unsuccessful:
Fixes PHP warnings caused by accessing properties on a null article item
when opening the Page Break modal in Joomla 6.
The Page Break modal can be opened without a loaded article item, which
caused warnings for id and checked_out in the article HtmlView.
Fixes #46901
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Front End com_banners |
| Labels |
Added:
PR-5.4-dev
|
||
| Category | Administration com_content Front End com_banners | ⇒ | Administration com_content |
Thanks for checking 👍
Yes, this fix is primarily for Joomla 6. I can rebase and retarget the PR to 6.0-dev if that’s preferred.
I have tested this item ✅ successfully on 69a0e27
Confirmed the fix for Joomla 6.1.0 beta 1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46908.
Thanks for testing and confirming 👍
| Labels |
Added:
bug
PR-6.0-dev
Removed: PR-5.4-dev |
||
@sathwikre As the fixed issue is specific for 6.x and does not happen in 5.4, I've allowed myself to rebase your PR to 6.1-dev and fix the conflict caused by changes made in the 6.0-dev branch in past at the same place. Please check if the changed file on GitHub shows what you expect.
@mariantanase Please test again, preferably on 6.0 and not 6.1, and submit the test result again. Thanks in advance.
I have tested this item ✅ successfully on d1c714c
Confirmed that the fix works as expected on Joomla 6.0.3 as well.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46908.
@sathwikre As the fixed issue is specific for 6.x and does not happen in 5.4, I've allowed myself to rebase your PR to 6.1-dev and fix the conflict caused by changes made in the 6.0-dev branch in past at the same place. Please check if the changed file on GitHub shows what you expect.
@mariantanase Please test again, preferably on 6.0 and not 6.1, and submit the test result again. Thanks in advance.
Thanks for rebasing and resolving the conflict 👍
I’ve reviewed the updated file and it looks correct to me.
Thanks for rebasing and resolving the conflict 👍
I’ve reviewed the updated file and it looks correct to me.
I have tested this item ✅ successfully on d1c714c
No more warnings after applying the fix on 6.0.3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46908.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46908.
I have tested this item ✅ successfully
It works too #46920
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46908.
@sathwikre Should this PR be rebased to 6.0-dev?