User tests: Successful: Unsuccessful:
Pull Request resolves #26322 .
For issue #26322 a partial solution was already merged ##27843.
This PR resolves the problem (missing title attributes) also for actionlog messages.
On your dashboard or in the actionlogs inspect messages or hover the links in the message.
Check different types of messages which contain different links.
No title attributes. A message looks like
User <a href=".../index.php?option=com_users&task=user.edit&id=15">chmst</a>
added new menu item <a href="../administrator/index.php?option=com_menus&task=item.edit&id=139">
Change Password (en-GB)</a>
All links have a title attribute.
User <a href="../administrator/index.php?option=com_users&task=user.edit&id=15" title="Edit User chmst">chmst</a>
added new menu item <a href="../administrator/index.php?option=com_menus&task=item.edit&id=139" title="Edit menu item Change Password (en-GB)">Change Password (en-GB)</a>
No documentation changes for guide.joomla.org needed
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration Language & Strings |
I have tested this item ✅ successfully on e9d0bb8
I verified the fix against the specific language keys modified in this PR (e.g., PLG_SYSTEM_ACTIONLOGS_CONTENT_ADDED, _UPDATED, etc.).
Before:
<a href=".../index.php?option=com_users&task=user.edit&id=147">krishnagandhi</a>
After:
The title attribute is correctly generated for these actions -><a href=".../index.php?option=com_users&task=user.edit&id=147" title="edit user krishnagandhi">krishnagandhi</a>
I noticed that other action types (like extension installations) use different language keys and are understandably unchanged by this specific patch. Should we open another PR to address those and complete the coverage?
Thank you for testing - I had forgotten to commit the other changes.
But make a new PR yourself, have fun!
| Labels |
Added:
Language Change
a11y
bug
PR-5.4-dev
|
||
The task is user.edit and as a super user I can edit.
Do we really want that the user can be changed here? But this is not in scope of this PR.
plus iirc user action log is restricted to super users
BUT I tend to agree that EDIT is possibly the wrong word and that SHOW is better. I want to read the user details and the only way to do that is with the task edit
The issue was labelled as feature - can also go into 6.1 or later, but continues a former already merged PR
@chmst According to https://github.com/joomla/joomla-cms?tab=readme-ov-file#which-branch-should-my-pull-request-target this PR should indeed be moved to 6.1-dev. There is nothing really broken without this PR.
Shall I rebase it for you, or will you do that?
accessibility errors are bugs
| Title |
|
||||||
| Category | Administration Language & Strings | ⇒ | Administration Language & Strings Installation Libraries Unit Tests |
I've rebased to 6.1, the language strings will be enhanced there. The conflicts should be resolved, when 6.1 has the upmerge done.
| Labels |
Added:
Feature
Unit/System Tests
PR-6.1-dev
Removed: bug PR-5.4-dev |
||
| Category | Administration Language & Strings Installation Libraries Unit Tests | ⇒ | Administration Language & Strings |
I've rebased to 6.1, the language strings will be enhanced there. The conflicts should be resolved, when 6.1 has the upmerge done.
@chmst @bembelimen I've allowed myself to fix the conflicts. PR should be ok for 6.1-dev now.
I will restore @krishnagandhicode 's test result in the issue tracker as it is still valid. The conflicts were unrelated to the changes in this PR, so it can be considered a clean branch update.
I have tested this item ✅ successfully on b4d03c0
Tested it successfully on 6.1.0-alpha3
I think Edit is good, because it actually opens the edit form.
| Status | Pending | ⇒ | Ready to Commit |
| Build | 5.4-dev | ⇒ | 6.1-dev |
RTC
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-02-17 07:57:39 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
RTC
Removed: Unit/System Tests |
||
thanks
The issue was labelled as feature - can also go into 6.1 or later, but continues a former already merged PR