User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This pull request (PR) updates the lists of files and folders to be deleted on update in script.php for the upcoming 5.4.3 release.
All files and folders added by this PR here are testing files from symfony composer dependencies, see PR #46765 for the removal of these files and folders from the package build.
Code review.
Or compare the full installation zip package created by Drone for this PR (or any other 5.4-dev PR after the merge of PR #46765 or from tomorrow on you can also use the latest 5.4-dev nightly build) with the full installation zip package of 5.4.2 and check which files and folders only exist in the 5.4.2 package-
Or update from 5.4.2 to the latest 5.4 nightly build to check the actual result, and update from 5.4.2 to the patched update package or custom update URL created by Drone for this PR here to check the expected result.
After an update from 5.4.2 to the latest 5.4 nightly build, the files and folders handled in this PR are still there.
After an update from 5.4.2 to the patched update package or custom update URL created by Drone for this PR here, the files and folders handled in this PR have been deleted.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_admin |
@richard67 can the script you used for this be added to the build folder and process to avoid the bus factor
@richard67 can the script you used for this be added to the build folder and process to avoid the bus factor
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46830.
@brianteeman The script is not ready yet as it still requires some manual adjustments to the code after using it. I hope to find the time latest when my term of duty as release manager for 5.4-dev will end, so it can be used in automated actions.
| Labels |
Added:
bug
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 9581dec
Tested with JBT and in extracting the full packages:
php cli/joomla.php update:joomla:remove-old-files before PR
jbt-54 # find . -type f | grep '/Test/'
./libraries/vendor/symfony/validator/Test/ConstraintValidatorTestCase.php
./libraries/vendor/symfony/translation-contracts/Test/TranslatorTest.php
./libraries/vendor/symfony/var-dumper/Test/VarDumperTestTrait.php
./libraries/vendor/symfony/http-client/Test/HarFileResponseFactory.php
./libraries/vendor/symfony/service-contracts/Test/ServiceLocatorTestCase.php
./libraries/vendor/symfony/service-contracts/Test/ServiceLocatorTest.php
./libraries/vendor/symfony/http-client-contracts/Test/TestHttpServer.php
./libraries/vendor/symfony/http-client-contracts/Test/HttpClientTestCase.php
./libraries/vendor/symfony/http-client-contracts/Test/Fixtures/web/index.php
jbt-54 # find . -name Test -type d
./libraries/vendor/symfony/validator/Test
./libraries/vendor/symfony/translation-contracts/Test
./libraries/vendor/symfony/var-dumper/Test
./libraries/vendor/symfony/http-client/Test
./libraries/vendor/symfony/service-contracts/Test
./libraries/vendor/symfony/http-client-contracts/Test
gh pr checkout 46830
543/ and 5.4.2 full release package as 542/
( cd 542 ; find . -print | sort > /tmp/542.txt )
( cd 543 ; find . -print | sort > /tmp/543.txt )
diff /tmp/542.txt /tmp/543.txt
| Status | Pending | ⇒ | Ready to Commit |
RTC
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-02-04 17:34:36 |
| Closed_By | ⇒ | muhme | |
| Labels |
Added:
RTC
|
||
Thank you @richard67 for your contribution. Thank you @brianteeman for testing.
I have tested this item ✅ successfully on dacf1d9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46830.