Joomla! Issue Tracker | Joomla! CMS #46816 - [5.4] Modules run getLayoutData() twice

No Code Attached Yet bug good first issue Performance

New
Medium
Build: 5.4-dev
# 46816

Hackwar
2 Feb 2026

Steps to reproduce the issue

Create a popular tags module, enable debugging and go to a page that displays the module. See that the query to get the information of the popular tags is run twice.

The problem is, that Dispatcher::dispatch() of the module calls $this->getLayoutData(), which runs all the methods to get the data and when it then later calls parent::dispatch() the parent method calls that again. So we are running this unnecessarily twice.

Hackwar - open - 2 Feb 2026

Hackwar - change - 2 Feb 2026

Labels

Added: bug Performance

Hackwar - labeled - 2 Feb 2026

joomla-cms-bot - change - 2 Feb 2026

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 2 Feb 2026

richard67 - comment - 2 Feb 2026

Can this cause issue #46751 ?

richard67 - comment - 2 Feb 2026

P.S.: Especially this comment #46751 (comment) regarding the twice.

Hackwar - comment - 2 Feb 2026

Nope, this isn't related.

brianteeman - comment - 2 Feb 2026

confirmed

Fedik - comment - 3 Feb 2026

~~Please specify in which module it happen.~~
I do not see it in mod_articles and mod_custom for example.

It is a bug in the module itself.

brianteeman - comment - 3 Feb 2026

as stated it is the popular tags module

Fedik - comment - 3 Feb 2026

Yes, just found, I had to read again, sorry 😄

Fedik - comment - 3 Feb 2026

The method dispatch() in this module need to remove.

And this code need to be moved to getLayoutData()

joomla-cms/modules/mod_tags_popular/src/Dispatcher/Dispatcher.php

Lines 42 to 44 in 7c94640

    
           if (!\count($displayData['list']) && !$displayData['params']->get('no_results_text')) { 
        
               return; 
        
           }