[#46812] - [6.1] Minor performance improvement for System - Language Filter plugin
- Pending
- Medium
- Build: 6.1-dev
- # 46812
- Diff
- joomdonation:improve_language_filter
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The System – Language Filter plugin currently calls LanguageHelper::getInstalledLanguages(0) multiple times, each time for one language in the loop. The method itself contains bunch of logic, including file system operator - which in general, slow.
This PR stores the result in a local variable so the method is called only once, reducing unnecessary filesystem work and slightly improving performance.
Testing Instructions
- Setup a multilingual website with Joomla 6.1
- Apply patch
- Access to random pages in frontend of your site with different languages.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with small performance improvement.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
tecpromotion
- | Title |
|
||||||
I have tested this item ✅ successfully on 0dca53f
I don't see, or expect to see, the performance improvement - but nothing was broken.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46812.