[#46809] - [5.4]Joomla.form.field xml code style
- Pending
- Medium
- Build: 5.4-dev
- # 46809
- Diff
- brianteeman:code_style
User tests: Successful: Unsuccessful:
Super minor PR just to remove some extra spaces and tabs
code review only
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I tested the code and anlyze some issue in code as trailing whitespace in line 31 and 36
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809.
I tested the code and anlyze some issue in code as trailing whitespace in line 31 and 36
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809.
Hi ompatwa000-svg, nice that you have noticed that, that is the purpose of Brian's PR, he detected those extra characters and his PR does something about that (removes them), once you have tested the PR and have confirmed/not confirmed that, you can press " View on Joomla! Issue Tracker " from the Joomla Patch Tester and validate/invalidate the test.
I have tested this item ✅ successfully on 1681b8f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809.
| Labels |
Added:
RTC
|
||
| Title |
|
||||||
I realised that it was a copy paste error so checked and found some more instances
| Status | Ready to Commit | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Removed:
RTC
|
||
I have tested this item ✅ successfully on 1681b8f
Hi @brianteeman, you have eagle eyes! (or possibly a great scanning tool) either way nice catch! :)
Checked BEFORE and AFTER file and confirm the spacing is fixed AFTER PR applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809.