[#46805] - [5.4] check ACL when display link to user edit form
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 46805
- Diff
- heelc29:5.4/checkacl-usereditlink
User tests: Successful: Unsuccessful:
Pull Request for Issue from @chmst #pbf26
Summary of Changes
Checks the ACL (Access Control List) to decide whether to display a link or just the name.
Testing Instructions
- login as an user who belongs to
Managergroup - view article or contact list and click on an user (which is not a super user) and click on it
- then login as superuser and change permission of user component for manager group; allow:
Access Administration Interfaceand deny:Edit
- login as an user who belongs to manager group again and click link again
Actual result BEFORE applying this Pull Request
1st try
2nd try
Expected result AFTER applying this Pull Request
name of user is only displayed - no link anymore
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact com_content |
I have tested this item ✅ successfully on 67d7f2b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46805.
I have tested this item ✅ successfully on 67d7f2b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46805.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
RMDQ
PR-5.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46805.
| Labels |
Added:
RTC
bug
Removed: RMDQ |
||
❌ Final test before merge with JBT
- Installed Blog Sample Data, Created manager, editor, to-be-deleted users, Created 3 contacts with linked users, created articles as users manager, editor, to-be-deleted, deleted the to-be-deleted user entry
- Seen 403 before in articles view and contacts and with user component permissions Edit Denied
- Applied PR with Patch Tester
- ✅ Articles/Contacts as Super User all Authors/Linked User entries are still linked names and the links are working
- ✅ '[ None ]' is still displayed for deleted user entry
- ✅ Articles/Contacts as manager other Authors/Linked User entries are only names and no more links
- ❌ Articles/Contacts as manager: The user's own entry is no longer linked; previously, the user's own entry was linked and opening the user entry worked in Articles/Contacts
- Changed user component permissions Edit Denied
- ✅ Articles/Contacts as manager all Authors/Linked User entries are only names and no more linked
@heelc29 Thank you for your contribution. In final testing I found with user component permissions edit enables, the user's own entry is no longer linked. Before the PR, the user's own entry was linked and opening the user entry worked in Articles and Contacts. Could you please check?
I have tested this item ✅ successfully on 67d7f2b
I have tested this successfully - thank you @heelc29!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46805.