[#46782] - [#46239] [5.4] Fix: Banner clients accept duplicates
- Pending
- Medium
- Build: 5.4-dev
- # 46782
- Diff
- kkbiswal:Joomlabracnh
- Foreign ID 46239
User tests: Successful: Unsuccessful:
Pull Request for Issue #45603
Alternative to PR #46239
Summary of Changes
client name must be like client, client (2), client (3), client (4).
pull request for the issue : #45603
Testing Instructions
-Go to Components → Banners → Clients in Joomla Administrator.
-Select an existing client,.
-Click Save as Copy multiple times.
-Verify that each new client is created with a unique name:
-Confirm that no duplicates are created in the database and all other save functionality works as expected.
Actual result BEFORE applying this Pull Request
Result: After clicking “Save as copy”, the name is generated as client, client (2), client (3), client (24), and so on.
Expected result AFTER applying this Pull Request
client, client (2), client (3), client (4).
I have changed the way to tget the correct out put as discused and mentioned by
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
Yes, definitely do that and send it again.
Thanks and regards
On Fri, Jan 30, 2026 at 5:29 PM Richard Fath @.***>
wrote:
richard67 left a comment (#46782)
#46782 (comment)@kkbiswal https://github.com/kkbiswal Is your PR here meant to replace
the other PR #46239 #46239 ?
And please mention the reference to the initial issue in your PR like the
other PR does. Finally please check code style errors reported by the CI
action on GitHub. Thanks.—
Reply to this email directly, view it on GitHub
#46782 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW53DXMUHMNTGQ35IHLNZ2D4JNBS7AVCNFSM6AAAAACTNUU466VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMRTGM2DSOBXGA
.
You are receiving this because you were mentioned.Message ID:
@.***>
I have tested this item ✅ successfully on 87e15ed
i analyze the code and i will sugest if we add some extra things like if we modify the clientmodel.php with updating preparetable it will beneficiar for us
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46782.
| Title |
|
||||||
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 3600cd6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46782.
I have tested this item ✅ successfully on 3600cd6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46782.
hi @richard67 i have added the issue reference in my description please check and let me know if anything i need to do.
I have tested this item ✅ successfully on 3600cd6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46782.
@kkbiswal I looked at the original issue and the discussion on other PR #46239 which fix this same issue and below are my suggestions:
- Only change Client Name on Save As Copy. For that, you should override save method of ClientModel, similar with how other components in Joomla handle this. See https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/components/com_contact/src/Model/ContactModel.php#L318-L333 for an example
- Don't write your own logic to generate Client Name like how you are doing at the moment. You can use similar logic which is implemented in Joomla core https://github.com/joomla/joomla-cms/blob/5.4-dev/libraries/src/MVC/Model/AdminModel.php#L958-L975
That should be good for now. If people still want to have Client Name unique, a new PR can be implemented which modify check method of ClientTable class https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/components/com_banners/src/Table/ClientTable.php#L75 to set an error to table object if client name is duplicate, similar with how alias is checked here https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/components/com_banners/src/Table/BannerTable.php#L226
I have tested this item ✅ successfully on 3600cd6
I have tested this item ✅ successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46782.
I have tested this item ✅ successfully on 3600cd6
Works!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46782.
| Title |
|
||||||
| Title |
|
||||||
I agree with @joomdonation 's comment above.
@kkbiswal Could you check and if possible implement his suggestions? Thanks in advance.
| Labels |
Added:
Updates Requested
bug
|
||
@richard67 okay. i will check and do the needfull.
I have tested this item ✅ successfully on 9a330cb
I have tested this item ✅ successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46782.
@kkbiswal Is your PR here meant to replace the other PR #46239 ? And please mention the reference to the initial issue in your PR like the other PR does. Finally please check code style errors reported by the CI action on GitHub. Thanks.