Feature PBF PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
29 Jan 2026

Summary of Changes

This is a base implementation for module versioning.

Testing Instructions

  1. Apply patch
  2. Make sure Database changes are executed, check if you have an entry for modules (id=14) in #__content_types
  3. Enable Versioning in Module component configuration
  4. Do changes on modules and switch versions, back and force
  5. Try different module type also 3rd part modules

Actual result BEFORE applying this Pull Request

No Versions for modules available

Expected result AFTER applying this Pull Request

Versions for modules available

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
2.00

avatar rdeutz rdeutz - open - 29 Jan 2026
avatar rdeutz rdeutz - change - 29 Jan 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2026
Category SQL Administration com_admin Postgresql com_modules Installation
avatar brianteeman
brianteeman - comment - 29 Jan 2026

@rdeutz please follow the convention to out the joomla version in the PR title - it makes it easier to see the version the pr should be tested against

avatar rdeutz rdeutz - change - 29 Jan 2026
Title
Feature/module versions
[6.1] Feature/module versions
avatar rdeutz rdeutz - edited - 29 Jan 2026
avatar rdeutz rdeutz - change - 29 Jan 2026
Labels Added: PR-6.1-dev
avatar rdeutz rdeutz - change - 29 Jan 2026
Title
[6.1] Feature/module versions
[6.1] Versions for Modules
avatar rdeutz rdeutz - edited - 29 Jan 2026
avatar brianteeman
brianteeman - comment - 29 Jan 2026

Please add the version note field

avatar brianteeman
brianteeman - comment - 29 Jan 2026

Please add Maximum Versions setting

avatar brianteeman
brianteeman - comment - 29 Jan 2026

all is looking good so far

avatar exlemor
exlemor - comment - 29 Jan 2026

For other testers, if you try to test this PR via Joomla Patch Tester even with the latest Nightly Build, you will get the error:
The file marked for modification does not exist: phpstan-baseline.neon

Use the Download package instead :)

avatar rdeutz rdeutz - change - 29 Jan 2026
Labels Added: Feature PBF
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2026
Category SQL Administration com_admin Postgresql com_modules Installation SQL Administration com_admin Postgresql com_modules Installation Layout
avatar rdeutz
rdeutz - comment - 29 Jan 2026

@brianteeman version note and history limit added

avatar brianteeman
brianteeman - comment - 29 Jan 2026

Content versioning is available in both the site and admin so I would expect the same for module versioning. Currently its only enabled for the admin

avatar brianteeman
brianteeman - comment - 29 Jan 2026

Tested with core modules in the admin ui and module versioning is working as expected - cool stuff

avatar rdeutz
rdeutz - comment - 29 Jan 2026

Content versioning is available in both the site and admin so I would expect the same for module versioning. Currently its only enabled for the admin

I think it is a fair request. I have looked into it and a polite description how module edit is implemented in the frontend is: interesting. I would like to discuss this with the maintainers and don't start implementing it at this stage. I will come back with a decision.

avatar vishalchincholi1
vishalchincholi1 - comment - 30 Jan 2026

Getting this error on locally while applying the patch
The file marked for modification does not exist: phpstan-baseline.neon

avatar brianteeman
brianteeman - comment - 30 Jan 2026

@vishalchincholi1

For other testers, if you try to test this PR via Joomla Patch Tester even with the latest Nightly Build, you will get the error:
The file marked for modification does not exist: phpstan-baseline.neon

Use the Download package instead :)

avatar manojLondhe manojLondhe - test_item - 30 Jan 2026 - Tested unsuccessfully
avatar manojLondhe
manojLondhe - comment - 30 Jan 2026

I have tested this item 🔴 unsuccessfully on 473ab99

Getting error while applying patch as The file marked for modification does not exist: phpstan-baseline.neon


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar brianteeman
brianteeman - comment - 30 Jan 2026
avatar brianteeman brianteeman - alter_testresult - 30 Jan 2026 - manojLondhe: Not tested
avatar rdeutz
rdeutz - comment - 30 Jan 2026

I have reverted the PHP Stan fixes to make testing easier. Now PHP Stan fails, please ignore this, it is expected.

avatar manojLondhe manojLondhe - test_item - 30 Jan 2026 - Tested successfully
avatar manojLondhe
manojLondhe - comment - 30 Jan 2026

I have tested this item ✅ successfully on 24ca80a

---
Tested as:

  1. Enabled versioning

  2. From admin area:

  • Verified versioning for couple of core modules
  • Verified versioning for couple of 3rd party modules
  1. From site area:
  • Verified versioning for couple of core modules
  • Verified versioning for couple of 3rd party modules
  1. Verified version note, compare versions, restore versions.

Works as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.
avatar brianteeman
brianteeman - comment - 30 Jan 2026

@manojLondhe how did you test versioning on the front end as that functionality does not exist

avatar manojLondhe
manojLondhe - comment - 30 Jan 2026
  1. Changes to module settings from site area are getting captured:

Edited module settings from site area
site-module-edit-1

Changes can be seen in version history diff
site-module-edit-2

  1. I, however, could not see Version Note field in site area
avatar crimle crimle - test_item - 30 Jan 2026 - Tested unsuccessfully
avatar crimle
crimle - comment - 30 Jan 2026

I have tested this item 🔴 unsuccessfully on 24ca80a

The button [Versions] appears correctly, but no versions are available after submitting several changes to the module. I tested modules of the type «Custom», «Tags popular» and «Articles».


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar brianteeman
brianteeman - comment - 30 Jan 2026

@crimle did you run the sql before testing

avatar crimle
crimle - comment - 30 Jan 2026

@crimle did you run the sql before testing

No, I did not, sorry. There is no testing instruction that tells me to run SQL before testing. Apart from that, how could I possibly do this on my Test Server?

avatar idefax
idefax - comment - 30 Jan 2026

I have tested this successfully. I used core custom module and a 3rd party slider module.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar crimle crimle - test_item - 30 Jan 2026 - Tested successfully
avatar crimle
crimle - comment - 30 Jan 2026

I have tested this item ✅ successfully on 24ca80a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar crimle
crimle - comment - 30 Jan 2026

After retesting I can confirm: it works!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar dautrich dautrich - test_item - 30 Jan 2026 - Tested successfully
avatar dautrich
dautrich - comment - 30 Jan 2026

I have tested this item ✅ successfully on 24ca80a

Tested with a small module "Custom HTML" and with a third party module ("DWD Weather Warning" from Thomas Hunziker).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar paternax paternax - test_item - 30 Jan 2026 - Tested successfully
avatar paternax
paternax - comment - 30 Jan 2026

I have tested this item ✅ successfully on 24ca80a

The ‘Versions’ button is also displayed when versioning is deactivated. This is somewhat confusing, as it does not occur to you that versioning still needs to be activated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar brianteeman
brianteeman - comment - 30 Jan 2026

@paternax that is not the intended behaviour. the versions button should not be present if versions is not enabled. can you please retest. Otherwise you should change your success to a failed test

avatar dautrich
dautrich - comment - 30 Jan 2026

@paternax @brianteeman
On my test site, the "Versions" button is only displayed, when versioning is enabled in the configuration. I just tested this again.

avatar brianteeman
brianteeman - comment - 30 Jan 2026

@dautrich thats my experience as well which is why I asked for a retest - maybe there is some scenario we didnt consider causing the button to be permanently visible

avatar exlemor exlemor - test_item - 30 Jan 2026 - Tested successfully
avatar exlemor
exlemor - comment - 30 Jan 2026

I have tested this item ✅ successfully on 24ca80a

I have successfully tested this with Olivier watching during PBF 2026 Friday... @rdeutz - please validate if this passes based on below:
Tested this on 2 installations, same results!

  1. Applying the PR, did NOT update the SQL for me, had to add SQL code into database via phpMyAdmin
  2. With core module and 3rd party extension changing 5-6 fields in multiples tabs including playing with Associations on a multi-lingual site, the PR does what it claims and shows/restores previous versions of the Module

HOWEVER, and this may be outside of scope or on purpose, the Permissions Tab values/data does NOT get restored (i.e. if you Allow, Deny or Inherit) the values stay the same even after a or multiple restores

Personally impressed that Versioning worked even with complex setup + multilingual associations = 🥰 😍


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.
avatar idefax idefax - test_item - 31 Jan 2026 - Tested successfully
avatar idefax
idefax - comment - 31 Jan 2026

I have tested this item ✅ successfully on 24ca80a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar gioacchino54
gioacchino54 - comment - 31 Jan 2026

I applied the patch, but id=14 is not reported in the database.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar dautrich
dautrich - comment - 31 Jan 2026

@gioacchino54
As mentioned in the testing instructions, you need to apply the SQL script from the patch manually, i.e. via phpMyAdmin.

avatar dusries
dusries - comment - 31 Jan 2026

I was able to test this successfully.
However, I did not see any (id=14) in #__content_types in the database.
Not even after clearing the browser cache.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar dautrich
dautrich - comment - 31 Jan 2026

@dusries
As mentioned in the testing instructions, you need to apply the SQL script from the patch manually, i.e. via phpMyAdmin.

avatar Razzo1987 Razzo1987 - test_item - 31 Jan 2026 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 31 Jan 2026

I have tested this item ✅ successfully on 24ca80a

Tested with multiple modules.

eg:
image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.
avatar gioacchino54 gioacchino54 - test_item - 31 Jan 2026 - Tested successfully
avatar gioacchino54
gioacchino54 - comment - 31 Jan 2026

I have tested this item ✅ successfully on 24ca80a

Successfully applied


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar gioacchino54
gioacchino54 - comment - 31 Jan 2026

@dautrich Sorry, I didn't see that.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar gioacchino54 gioacchino54 - test_item - 31 Jan 2026 - Tested successfully
avatar gioacchino54
gioacchino54 - comment - 31 Jan 2026

I have tested this item ✅ successfully on 24ca80a

Successfully applied


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar gioacchino54
gioacchino54 - comment - 31 Jan 2026

Tested correctly and I can see the module versions.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar rdeutz
rdeutz - comment - 31 Jan 2026

I reapplied the PHP Stan fix to get the testing green, I would say we have enough manual tests and it is save to merge.

avatar rdeutz rdeutz - change - 31 Jan 2026
Status Pending Ready to Commit
avatar rdeutz
rdeutz - comment - 31 Jan 2026

Thanks to all the testers, RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

avatar brianteeman
brianteeman - comment - 31 Jan 2026

@rdeutz are you leaving front end versioning to a new issue?

avatar rdeutz
rdeutz - comment - 31 Jan 2026

@rdeutz are you leaving front end versioning to a new issue?

Kind of, I will wait till a decision is made and then look what we can do.

avatar torstenhoppe torstenhoppe - test_item - 2 Feb 2026 - Tested successfully
avatar torstenhoppe
torstenhoppe - comment - 2 Feb 2026

I have tested this item ✅ successfully on 0bdb14b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.

Add a Comment

Login with GitHub to post a comment