User tests: Successful: Unsuccessful:
Fixes #46764
The Symfony HttpClient packages currently include Test directories in Joomla release archives. These folders contain test-only classes and are not required in production distributions.
This change updates the build system to exclude:
As a result, release packages no longer ship unnecessary test files, reducing package size and avoiding unintended exposure of test code.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Repository |
| Labels |
Added:
PR-5.4-dev
|
||
Thanks for the guidance. I’ve updated the build cleanup rules to follow the existing pattern as suggested.
I think you will find it better to make the change here
https://github.com/joomla/joomla-cms/blob/5.4-dev/build/build.php#L169-L173
run_and_check('rm -rf libraries/vendor/symfony/*/Test');
That way it will also pick up libraries\vendor\symfony\service-contracts\Test
Thanks for the suggestion. I’ve updated the build cleanup to use a wildcard removal for Symfony Test directories, following the existing cleanup pattern.
Thanks for the guidance. I’ve updated the cleanup section so the Symfony */Test directories are removed before the */Tests rule, and I’ve removed the extra comment as suggested.
This now follows the existing ordering pattern and also correctly handles additional Symfony test folders like service-contracts/Test.
Please let me know if anything else needs adjusting.
| Title |
|
||||||
I’ve applied your suggested change and committed the updated ordering. Thanks for the review!
Fixed formatting as requested (tab restored, empty line removed).
Ready for final review. Thanks!
| Labels |
Added:
bug
|
||
I have tested this item ✅ successfully on 2798e8e
Thanks for testing and confirming. Ready for merge when convenient.
I have tested this item ✅ successfully on 2798e8e
I have tested this PR successfully
Joomla Version: 5.4.3-dev
PHP Version: 8.2.12
OS: Windows 11
Environment: XAMPP
Test Results
All Test directories were properly identified
The wildcard pattern approach works correctly
No errors during testing
I have tested this item ✅ successfully on 2798e8e
According to I study and anlyze the code according to that i will say given code is correct and i will propose that if you can add some comands in clean_checkout function so that it can remove libraries/vendor/symfony/http-client-contracts/Test.
Thanks for testing and the suggestion 👍
The directory libraries/vendor/symfony/http-client-contracts/Test is already covered by the existing wildcard cleanup:
libraries/vendor/symfony/*/Test
This was added intentionally to handle current and future Symfony packages consistently, so no additional command should be required.
This is not the correct way to do it. see this example
https://github.com/joomla/joomla-cms/blob/5.4-dev/build/build.php#L129-L130