bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar sathwikre
sathwikre
28 Jan 2026

Fixes #46764

The Symfony HttpClient packages currently include Test directories in Joomla release archives. These folders contain test-only classes and are not required in production distributions.

This change updates the build system to exclude:

  • libraries/vendor/symfony/http-client-contracts/Test
  • libraries/vendor/symfony/http-client/Test

As a result, release packages no longer ship unnecessary test files, reducing package size and avoiding unintended exposure of test code.

avatar sathwikre sathwikre - open - 28 Jan 2026
avatar sathwikre sathwikre - change - 28 Jan 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2026
Category Repository
avatar brianteeman
brianteeman - comment - 28 Jan 2026

This is not the correct way to do it. see this example

https://github.com/joomla/joomla-cms/blob/5.4-dev/build/build.php#L129-L130

avatar sathwikre sathwikre - change - 28 Jan 2026
Labels Added: PR-5.4-dev
avatar sathwikre
sathwikre - comment - 28 Jan 2026

Thanks for the guidance. I’ve updated the build cleanup rules to follow the existing pattern as suggested.

avatar brianteeman
brianteeman - comment - 28 Jan 2026

I think you will find it better to make the change here

https://github.com/joomla/joomla-cms/blob/5.4-dev/build/build.php#L169-L173

run_and_check('rm -rf libraries/vendor/symfony/*/Test');

That way it will also pick up libraries\vendor\symfony\service-contracts\Test

avatar sathwikre
sathwikre - comment - 29 Jan 2026

Thanks for the suggestion. I’ve updated the build cleanup to use a wildcard removal for Symfony Test directories, following the existing cleanup pattern.

avatar sathwikre
sathwikre - comment - 29 Jan 2026

Thanks for the guidance. I’ve updated the cleanup section so the Symfony */Test directories are removed before the */Tests rule, and I’ve removed the extra comment as suggested.
This now follows the existing ordering pattern and also correctly handles additional Symfony test folders like service-contracts/Test.

Please let me know if anything else needs adjusting.

avatar muhme muhme - change - 29 Jan 2026
Title
Exclude Symfony HTTP client test folders from release packages
[5.4] Exclude Symfony HTTP client test folders from release packages
avatar muhme muhme - edited - 29 Jan 2026
avatar sathwikre
sathwikre - comment - 29 Jan 2026

I’ve applied your suggested change and committed the updated ordering. Thanks for the review!

avatar brianteeman
brianteeman - comment - 29 Jan 2026

sorry I must have made a mistake - please put the tab back and remove the empty line

image

Then it should be complete

avatar sathwikre
sathwikre - comment - 29 Jan 2026

Fixed formatting as requested (tab restored, empty line removed).
Ready for final review. Thanks!

avatar sathwikre sathwikre - change - 29 Jan 2026
Labels Added: bug
avatar brianteeman brianteeman - test_item - 29 Jan 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 29 Jan 2026

I have tested this item ✅ successfully on 2798e8e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46765.

avatar sathwikre
sathwikre - comment - 29 Jan 2026

Thanks for testing and confirming. Ready for merge when convenient.

avatar 465645 465645 - test_item - 30 Jan 2026 - Tested successfully
avatar 465645
465645 - comment - 30 Jan 2026

I have tested this item ✅ successfully on 2798e8e

I have tested this PR successfully
Joomla Version: 5.4.3-dev
PHP Version: 8.2.12
OS: Windows 11
Environment: XAMPP
Test Results
All Test directories were properly identified
The wildcard pattern approach works correctly
No errors during testing


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46765.
avatar ompatwa000-svg ompatwa000-svg - test_item - 30 Jan 2026 - Tested successfully
avatar ompatwa000-svg
ompatwa000-svg - comment - 30 Jan 2026

I have tested this item ✅ successfully on 2798e8e

According to I study and anlyze the code according to that i will say given code is correct and i will propose that if you can add some comands in clean_checkout function so that it can remove libraries/vendor/symfony/http-client-contracts/Test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46765.

avatar sathwikre
sathwikre - comment - 30 Jan 2026

Thanks for testing and the suggestion 👍

The directory libraries/vendor/symfony/http-client-contracts/Test is already covered by the existing wildcard cleanup:

libraries/vendor/symfony/*/Test

This was added intentionally to handle current and future Symfony packages consistently, so no additional command should be required.

Add a Comment

Login with GitHub to post a comment