[#46762] - [5.4] Menu item : add inline help button
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 46762
- Diff
- conseilgouz:inlinehelp
User tests: Successful: Unsuccessful:
Summary of Changes
Add inlinehelp toggle button for menu item
Testing Instructions
Edit a menu item and play with inlinehelp toggle button.
Actual result BEFORE applying this Pull Request
- no inlinehelp button
- description shown
Expected result AFTER applying this Pull Request
- Inlinehelp toggle button in toolbar next to help button.
- Descriptions hidden by default
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
tecpromotion
- | Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
PR-5.4-dev
|
||
Thank you for telling me.
It has been fixed.
Pascal
I have tested this item ✅ successfully on b9f7e81
The desired behavior after applying the patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.
Before
After
I have tested this item ✅ successfully on b9f7e81
Hello @conseilgouz, Merci, Thank you for the fix, I was now able to test it successfully! :)
Tested it in Light and Dark modes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.
Thank you both of you for the tests.
Sorry I messed up first : I also tried to implement this on menus (which uses menu view), it did not work and i took the wrong file in the first version of this PR. After checking menus, it does not contain any description, so it's useless.
Pascal
Even if it is a small change, but it adds new functionality to that form. Therefore it has to be rebased to 6.1-dev. See also https://github.com/joomla/joomla-cms?tab=readme-ov-file#which-branch-should-my-pull-request-target .
We (maintainers) will do that when it is appropriate.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.
| Labels |
Added:
Feature
RMDQ
|
||
I have tested this item ✅ successfully on a07a938
Before applying patch there is no Toggle Inline Help button but after applying patch button added there in home menu
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.
I have tested this item ✅ successfully on a07a938
test successfull
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.
I have tested this item ✅ successfully on a07a938
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.
@conseilgouz, sorry ;( but I do NOT see an inline Help Button next to the ? Help button in the toolbar of Menu Items after the Patch is applied.
Test environment Joomla 5.4.2 then also tested it with Joomla 5.4.3-dev (Nightly Build from last night)