[#46755] - [6.1] Complimentary to #46353
- Pending
- Medium
- Build: 6.1-dev
- # 46755
- Diff
- dgrammatiko:6.1-dev/tmpl_complimentary
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Align the code for loading template language files to use the override functionality instead of the replacing one.
Testing Instructions
- Go to
administrator/index.php?option=com_templates&view=template&id=245&file=L2Vycm9yLnBocA%3D%3D&isMedia=0and check that all the language strings are correct
- Create a menu for the configuration of the template and then visit that link in the frontend (logged in as admin)
Actual result BEFORE applying this Pull Request
Nothing broken
Expected result AFTER applying this Pull Request
Nothing broken
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Front End com_config |
I have tested this item ✅ successfully on 1b61ec8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46755.
I have tested this item ✅ successfully on 1b61ec8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46755.
I have tested this item ✅ successfully on 1b61ec8
I tested this issue, and it was tested successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46755.
I have tested this item ✅ successfully on 1b61ec8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46755.
I have tested this item ✅ successfully on 1b61ec8
Hi @dgrammatiko, I was able to test this successfully -
Checked all of these constants:
JERROR_LAYOUT_PAGE_NOT_FOUND
JERROR_LAYOUT_ERROR_HAS_OCCURRED_WHILE_PROCESSING_YOUR_REQUEST
JERROR_LAYOUT_NOT_ABLE_TO_VISIT
JERROR_LAYOUT_AN_OUT_OF_DATE_BOOKMARK_FAVOURITE
JERROR_LAYOUT_MISTYPED_ADDRESS
JERROR_LAYOUT_SEARCH_ENGINE_OUT_OF_DATE_LISTING
JERROR_LAYOUT_YOU_HAVE_NO_ACCESS_TO_THIS_PAGE
JERROR_LAYOUT_GO_TO_THE_HOME_PAGE
JERROR_LAYOUT_HOME_PAGE
JERROR_LAYOUT_PLEASE_CONTACT_THE_SYSTEM_ADMINISTRATOR
JERROR_LAYOUT_PREVIOUS_ERROR
Just 1 quick note, after I applied the PR the first time - the first time I changed some settings in the Backend and then went back to the Frontend, I got a Forbidden error message and had to clear cache before it would work - and then I tried 3-4 replicating the issue and couldn't :/ so glitch I hope/assume... but thought I should mention it!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46755.
I have tested this item ✅ successfully on 1b61ec8
I tested this issue, and it was tested successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46755.