PBF bug PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
21 Jan 2026

Summary of Changes

This PR is needed to be prepared for updating https://github.com/web-auth/webauthn-lib in future versions of Joomla.
These are adjustments that were missing or overlooked during the last upgrade from v2.1.7 to v4.3.0 (#39123 and #39134).


AuthenticatorSelectionCriteria does not have a constructor 33fca93:

Deprecation:

Remove:


WebAuthn\Server constructor invoked with 2 parameters e83cac3:

Make third parameter of Server class optional, so no hack with ReflectionClass is necessary.


Deprecated class Webauthn\TokenBinding\IgnoreTokenBindingHandler f998cd5:

Deprecation:


Deprecated method forUnsecuredSigner() of class Lcobucci\JWT\Configuration b529689:

As we only use the parser function, we can use it directly:
https://github.com/lcobucci/jwt/blob/4d7de2fe0d51a96418c0d04004986e410e87f6b4/src/Configuration.php#L44


Testing Instructions

  • use passkey as login and multifactor authentication
  • do a code review based on comments above (and phpstan)

Note: To test the changes of plugins/system/webauthn/src/MetadataRepository.php another pull request #45708 is necessary > merged; you have to enable the system webauth plugin option attestation support

Actual result BEFORE applying this Pull Request

passkey working

Expected result AFTER applying this Pull Request

passkey working

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 21 Jan 2026
avatar heelc29 heelc29 - change - 21 Jan 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2026
Category Libraries Front End Plugins
19bd589 21 Jan 2026 avatar heelc29 cs
avatar heelc29 heelc29 - change - 21 Jan 2026
Labels Added: PR-6.1-dev
avatar heelc29 heelc29 - change - 26 Jan 2026
Labels Added: PBF bug
avatar heelc29 heelc29 - change - 26 Jan 2026
The description was changed
avatar heelc29 heelc29 - edited - 26 Jan 2026
avatar heelc29 heelc29 - change - 26 Jan 2026
The description was changed
avatar heelc29 heelc29 - edited - 26 Jan 2026
avatar Rajat-1804 Rajat-1804 - test_item - 31 Jan 2026 - Tested successfully
avatar Rajat-1804
Rajat-1804 - comment - 31 Jan 2026

I have tested this item ✅ successfully on fe8369a

I have tested this item ✅ successfully

Environment: Windows/XAMPP, Joomla 6.1-dev

Code Review:
✅ Verified Server constructor third parameter is now optional
✅ Removed deprecated TokenBindingHandler usage
✅ AuthenticatorSelectionCriteria uses default constructor (parameters removed)
✅ Replaced deprecated Configuration::forUnsecuredSigner() with Parser
✅ All PHP syntax checks passed

Functional Test:
✅ WebAuthn passkey login works correctly
✅ New authenticator registration works
✅ No PHP errors or deprecation warnings

Result: Code quality improvements successfully applied. Ready for future WebAuthn library upgrades.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46735.

Add a Comment

Login with GitHub to post a comment