Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4673] - Remove duplicate path in JLayoutFile

? Success
Referenced as Related to: # 4776

User tests: Successful: Unsuccessful:

avatar nicksavov
nicksavov
15 Oct 2014

Fixes #4097

avatar nicksavov nicksavov - open - 15 Oct 2014
avatar jissues-bot jissues-bot - change - 15 Oct 2014
Labels Added: ?
avatar wilsonge
wilsonge - comment - 16 Oct 2014

Just cause I'm an ass I really hate to see these things in if statements personally. Personally would much rather see 

$this->fullPath = JPath::find($this->includePaths, $rawPath);

if ($this->fullPath)
{
    // Blah Blah Blah.....
}

As it looks cleaner. But as I say just a personal thing. :+1: though

avatar nicksavov
nicksavov - comment - 16 Oct 2014

I agree. I only did that because I thought that was the preference. If we can go either way, we could make the assignment earlier, and use the variable for https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/layout/file.php#L137 as well.

avatar nicksavov
nicksavov - comment - 16 Oct 2014

Nevermind. Forget the last comment.

avatar joomdonation
joomdonation - comment - 16 Oct 2014

:+1: @wilsonge

avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar nicksavov
nicksavov - comment - 16 Oct 2014

Done. The commits should be squashed though.

avatar nicksavov
nicksavov - comment - 16 Oct 2014

Done. The commits should be squashed though. I'm guessing a committer does that? Or should I do that on my end?

avatar infograf768
infograf768 - comment - 16 Oct 2014

Will do

avatar nicksavov
nicksavov - comment - 16 Oct 2014

Thanks JM!

avatar infograf768
infograf768 - comment - 16 Oct 2014

Merged with 20ca941
thanks

avatar infograf768 infograf768 - close - 16 Oct 2014
avatar infograf768 infograf768 - change - 16 Oct 2014
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-10-16 07:49:45

Add a Comment

Login with GitHub to post a comment