RTC Unit/System Tests PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
20 Jan 2026

Summary of Changes

add unit test fore some form rules
also covers updated OptionsRule (#46608)

Testing Instructions

phpunit

Expected result AFTER applying this Pull Request

more tests

avatar heelc29 heelc29 - open - 20 Jan 2026
avatar heelc29 heelc29 - change - 20 Jan 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jan 2026
Category Unit Tests
9388f52 20 Jan 2026 avatar heelc29 cs
avatar heelc29 heelc29 - change - 20 Jan 2026
Labels Added: Unit/System Tests PR-5.4-dev
avatar richard67 richard67 - test_item - 21 Jan 2026 - Tested successfully
avatar richard67
richard67 - comment - 21 Jan 2026

I have tested this item ✅ successfully on 8ae628e

Tested by review:

  • Reviewed that test cases and test data make sense.
  • Checked in logs of unit tests CI action that more tests and assertions have run for this PR compared to the current 5.4-dev branch, and that no new PHP deprecation messages were created by the new test cases.
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.
avatar 465645 465645 - test_item - 30 Jan 2026 - Tested successfully
avatar 465645
465645 - comment - 30 Jan 2026

I have tested this item ✅ successfully on 6a1e2c0

Tests look correct based on the regex. Quick question: Should we add a test case for whitespace (e.g., ' true ')? I assume the BooleanRule is intended to be strict and reject untrimmed values, so adding that as a negative test case explicitly would confirm that behavior.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.

avatar 465645 465645 - test_item - 30 Jan 2026 - Tested successfully
avatar 465645
465645 - comment - 30 Jan 2026

I have tested this item ✅ successfully on 6a1e2c0

Tests look correct based on the regex. Quick question: Should we add a test case for whitespace (e.g., ' true ')? I assume the BooleanRule is intended to be strict and reject untrimmed values, so adding that as a negative test case explicitly would confirm that behavior.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.

avatar 465645 465645 - test_item - 30 Jan 2026 - Tested successfully
avatar 465645
465645 - comment - 30 Jan 2026

I have tested this item ✅ successfully on 6a1e2c0

Tests look correct based on the regex. Quick question: Should we add a test case for whitespace (e.g., ' true ')? I assume the BooleanRule is intended to be strict and reject untrimmed values, so adding that as a negative test case explicitly would confirm that behavior.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.

avatar 465645 465645 - test_item - 30 Jan 2026 - Tested successfully
avatar 465645
465645 - comment - 30 Jan 2026

I have tested this item ✅ successfully on 6a1e2c0

Tests look correct based on the regex. Quick question: Should we add a test case for whitespace (e.g., ' true ')? I assume the BooleanRule is intended to be strict and reject untrimmed values, so adding that as a negative test case explicitly would confirm that behavior.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.

avatar richard67 richard67 - alter_testresult - 3 Feb 2026 - richard67: Tested successfully
avatar richard67 richard67 - change - 3 Feb 2026
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 3 Feb 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46723.

avatar muhme muhme - change - 4 Feb 2026
Labels Added: RTC

Add a Comment

Login with GitHub to post a comment