[#46719] - [5.4] Content data-transitions attribute is inherited from the first allowed item
- Pending
- Medium
- Build: 5.4-dev
- # 46719
- Diff
- Denitz:patch-33
User tests: Successful: Unsuccessful:
Summary of Changes
In list of articles, if you can make a transition for an item but not for the next item in the list, the data-transitions attribute is inherited from the previously allowed item.
In short: $dataTransitionsAttribute variable is not re-initialized inside foreach cycle.
Additionally, data-transitions attribute and transition IDs detection is not required when Workflows are disabled.
Testing Instructions
With enabled Workflows:
Browse a list of articles in admin panel, i.e. two articles from different categories.
The permissions should be configured in a way that you can execute transitions for the 1st article, but not for the next.
With disabled Workflows:
Open list of articles.
Actual result BEFORE applying this Pull Request
With enabled Workflows:
See that both articles have data-transitions attribute of article , even though it should be missed for the 2nd item (no permissions).
With disabled Workflows:
See useless data-transitions attribute for of each article.
Expected result AFTER applying this Pull Request
With enabled Workflows:
See that data-transitions attribute of article <tr> element is only presented where permissions are allowed.
With disabled Workflows:
No useless data-transitions attribute for of each article.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Title |
|
||||||
| Labels |
Added:
PR-5.4-dev
|
||||||
I have tested this item ✅ successfully on d5b3e3f
Tested Successfully works after applied patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46719.
I have tested this item 🔴 unsuccessfully on d5b3e3f
Hi,
I've tested this item unsuccessful unfortunately.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46719.
This part failed for me:
This part of the test failed: See that data-transitions attribute of article element is only presented where permissions are allowed.
This is the markup i see when i apply the patch via the patch tester:
This is the admin view:
The logged in user has no rights for the workflow, stage and transition of the top article item test567.
I have tested this item 🔴 unsuccessfully on d5b3e3f
When applying the patch I still see the data-transitions for articles that don´t have the transitions allowed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46719.
@Denitz can you please confirm the expected results with this pr applied for a workflow article where the user doesnt have the required permissions and how to set those permissions.
From the screenshots above it suggests that you will still get the data-transitions element but with no values
Steps performed:
- Two categories were created.
- Two users were created.
- Workflows were enabled.
- Transitions for one stage were selected, and "Execute Transition" permission was granted to the first user but not to the second user across all relevant settings.
- One article was created by the first user and another by the second user.
Result:
In the article list in the admin view:
<tr class="row1" data-draggable-group="17" data-transitions="1,2,3,4,5,6,7">
<tr class="row0" data-draggable-group="16" data-transitions="1,2,3,4,5,6,7">
| Labels |
Added:
PBF
bug
|
||
@brianteeman @TLWebdesign @superknutsel I've added a change, you should not see empty data-transitions anymore.
I have tested this item ✅ successfully on d5b3e3f
I tested this issue, and it was tested successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46719.