User tests: Successful: Unsuccessful:
Pull Request for Issue #46643 .
We're not just calling the setFrom function form PHP Mailer but we are also setting the Sender variable when we call setSender function from the Mail class. This makes sure when we override the sender information thru setSender this does not get undone by the createMailer function in the MailerFactory class. (the change introduced in PR #46431.
send e-mail via an extension like this:
$mailer = Factory::getContainer()->get(MailerFactoryInterface::class)->createMailer();
$mailer->setSender('test@example.com');
$mailer->addRecipient('me@example.com');
$mailer->setSubject('Test');
$mailer->setBody('Test body');
$mailer->send();
or any other way but setSender should be set to set a custom sender.
The e-mail address from the global configuration is used. as the "Envelope sender".
The e-mail address set using the setSender function is used instead.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.4-dev
|
||
| Title |
|
||||||
I have tested this item ✅ successfully on d603cb9
System tests are passing without my workaround in DPCalendar
We have another issue now which might make it necessary to revert the initial PR. See this comment there (and further comments below that): #46431 (comment)
We need some smart people to confirm this is a legitimate fix. Not just two human tests.