User tests: Successful: Unsuccessful:
Minor Fixes
Views could not be opened during the init event.
Major Updates
See https://github.com/ryersondmp/sa11y/releases/tag/4.4.0
Apply pr and run npm i
Thanks @adamchaboryk
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | NPM Change Front End Plugins |
| Labels |
Added:
NPM Resource Changed
PR-6.1-dev
|
||
Should we also increase the plugin version to reflect the update of the underlying dependency?
https://github.com/joomla/joomla-cms/blob/6.1-dev/plugins/system/jooa11y/jooa11y.xml
Like it was done for TinyMCE.
i can do that if you want
Thanks Brian!
Personally, I would find it easier to follow, basically, it's similar to the TinyMCE Editor plugin, a wrapper around the library. But I'm not sure whether we have handled it this way in the past or whether this is how it is intended to be? @HLeithner
if my memory is correct the first release of the plugin (which was a fork of sa11y) was numbered 4.1 as that was the release of joomla it was introduced with.
i have no idea why i bumped the xml version to 4.2 with #37092
we switched to using native sa11y 3.0.8 with #42780 in Joomla 5.1
so the version in the plugin xml has never matched the sa11y release.
I can see the benefits of it being updated with a sa11y release but it should be done by our build tools (as we do with tinymce) otherwise it will be forgotten
I can see the benefits of it being updated with a sa11y release but it should be done by our build tools (as we do with tinymce) otherwise it will be forgotten
Thanks for the tip, I hadn't noticed that before. I'll test this PR later this evening.
All other plugins uses the original version number when they have been introduced.
I have tested this item ✅ successfully on 6171e01
I tested the plugin with all tests I have for accessibility issues. Updated a site from 6.0 with the update file from this PR.
Everything works as before, I don't see any differences. The enhancements and new features seem to be for use cases which are not in my repertoire of a11y issues.
I have now tested it and also tried out some of the new/improved rules from the release notes. It works as it should.
What doesn't work for me at all is the color filter feature, but I couldn't get that to work before the update either. Can you give me a tip on what I'm doing wrong @brianteeman ?
not you. looks like a bug somewhere
Hi all, the last few Sa11y updates have mostly been performance/architecture enhancements, tweaks to rulesets, etc — no significant changes to front end/UI.
@LadySolveig can you please let me know what browser/OS you're using?
Thank you @adamchaboryk for your message. I am testing on Linux Mint in both the Brave browser and Firefox.
It is more likely to be related to the implementation in the plugin, as the color filter function works without any issues on your demo page in both browsers for me.
Neither in the combination of Joomla 6.0 with sa11y 4.3.5, nor Joomla 6.1 with sa11y 4.3.5 and this patch for the update to sa11y 4.4.0 did the colour filter work for me.
What I've found so far. The svg and the container are injected by the js.
<div id="sa11y-colour-filters">
<!-- DaltonLens SVG filters to simulate color vision deficiencies -->
<svg id="sa11y-svg-filters" aria-hidden="true" xmlns="http://www.w3.org/2000/svg">
<filter id="sa11y-protanopia" color-interpolation-filters="linearRGB">
<feColorMatrix type="matrix" in="SourceGraphic" values="
0.10889,0.89111,-0.00000,0,0
0.10889,0.89111,0.00000,0,0
0.00447,-0.00447,1.00000,0,0
0,0,0,1,0"></feColorMatrix>
</filter>
<filter id="sa11y-deuteranopia" color-interpolation-filters="linearRGB">
<feColorMatrix type="matrix" in="SourceGraphic" values="
0.29031,0.70969,-0.00000,0,0
0.29031,0.70969,-0.00000,0,0
-0.02197,0.02197,1.00000,0,0
0,0,0,1,0"></feColorMatrix>
</filter>
<filter id="sa11y-tritanopia" color-interpolation-filters="linearRGB">
<feColorMatrix type="matrix" in="SourceGraphic" result="ProjectionOnPlane1" values="
1.01354, 0.14268, -0.15622, 0, 0
-0.01181, 0.87561, 0.13619, 0, 0
0.07707, 0.81208, 0.11085, 0, 0
7.92482, -5.66475, -2.26007, 1, -0.2"></feColorMatrix>
<feComponentTransfer in="ProjectionOnPlane1" result="ProjectionOnPlane1">
<feFuncA type="discrete" tableValues="0 0 0 0 1"></feFuncA>
</feComponentTransfer>
<feColorMatrix type="matrix" in="SourceGraphic" result="ProjectionOnPlane2" values="
0.93337, 0.19999, -0.13336, 0, 0
0.05809, 0.82565, 0.11626, 0, 0
-0.37923, 1.13825, 0.24098, 0, 0
0,0,0,1,0"></feColorMatrix>
<feBlend in="ProjectionOnPlane1" in2="ProjectionOnPlane2" mode="normal"></feBlend>
</filter>
<filter id="sa11y-monochromacy">
<feColorMatrix values="0.299,0.587,0.114,0,0,0.299,0.587,0.114,0,0,0.299,0.587,0.114,0,0,0,0,0,1,0"></feColorMatrix>
</filter>
</svg></div>This css rule seems a bit strange to me, should that perhaps be 100vw for width?
https://github.com/ryersondmp/sa11y/blob/725fe440db65eed55ba46e57a28354e1ee518982/src/css/sa11y.css#L152
But the actual problem in our implementation is that it cannot find the resource for the SVG – for the actual filter.
For example:
[data-sa11y-filter="tritanopia"] :not(sa11y-control-panel, sa11y-dismiss-tooltip) {
filter: url(#sa11y-tritanopia?v=176643);
}If I remove the version appendix like this
filter: url(#sa11y-tritanopia);and change the width to 100vw it works like expected.
I think we need an exception here for asset management during the build. @dgrammatiko
I have created a separate issue, as it has nothing to do with the actual update of the library.
I have tested this item ✅ successfully on 6171e01
Except for the problem with the colour filter, everything works after the update as expected.
The bug with the colour filter is unrelated, so I am marking the test as successful here and opened a new issue.
| Status | Pending | ⇒ | Ready to Commit |
RTC
I’ll add the required exception in the build tools
Thanks @dgrammatiko - done, but a test or your opinion would be great. #46609
| Labels |
Added:
RTC
|
||
| Category | NPM Change Front End Plugins | ⇒ | NPM Change |
@brianteeman For your information, I merged the 6.1 branch here after the release of 6.1.0-alpha2. So tiny is already done.
grrrh i hate it when commits are made directly
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-12-23 12:47:22 |
| Closed_By | ⇒ | HLeithner |
You all are fast!!
Thanks @LadySolveig for pointing out the wrong unit!! I packaged a couple fixes in Sa11y 4.4.1,.
You all are fast!!
Thanks @LadySolveig for pointing out the wrong unit!! I packaged a couple fixes in Sa11y 4.4.1.
The TinyMCE update has already been merged with PR #46592 . This PR here just fixes the missing version update in the
plugins/editors/tinymce/tinymce.xmlfile, which has been forgotten with the mentioned PR.This just for explanation for testers. Thanks @brianteeman for fixing that.