RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar stefanoel
stefanoel
17 Dec 2025

Pull Request for Issue #46562 .

Summary of Changes

On line 86 of /modules/mod_breadcrumbs/src/Helper/BreadcrumbsHelper.php edited the value assigned to $item->link for the home page in the getHomeItem function:

$item->link = 'index.php?Itemid=' . $home->id;

the $item->link was ignoring some params in $home->link so that it results different from the Home link took from the Pathway.
In tmpl/default.php code, lines 33-38 check if there are duplicated entries

        // Get rid of duplicated entries on trail including home page when using multilanguage
        for ($i = 0; $i < $count; $i++) {
            if ($i === 1 && !empty($list[$i]->link) && !empty($list[$i - 1]->link) && $list[$i]->link === $list[$i - 1]->link) {
                unset($list[$i]);
            }
        }

looking also for duplicated home pages in a multilanguage site.
But with different ->link values the two Home links won't match, so they are both visible in the output.

Testing Instructions

In a multilanguage site, a language specific menu structure:

  • Home
    • News
    • etc...
  • etc...

mod_breadcrumbs config:

Home: show
Text for home entry: empty, no value
Last: show

Actual result BEFORE applying this Pull Request

Home > Home > News

Expected result AFTER applying this Pull Request

Home > News

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar stefanoel stefanoel - open - 17 Dec 2025
avatar stefanoel stefanoel - change - 17 Dec 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Dec 2025
Category Modules Front End
avatar tecpromotion tecpromotion - change - 17 Dec 2025
Title
Fix: mod_breadcrumbs duplicates Home link in multilanguage
[5.4] Fix: mod_breadcrumbs duplicates Home link in multilanguage
avatar tecpromotion tecpromotion - edited - 17 Dec 2025
avatar alikon alikon - test_item - 20 Dec 2025 - Tested successfully
avatar alikon
alikon - comment - 20 Dec 2025

I have tested this item ✅ successfully on a4d62f6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46581.

avatar exlemor exlemor - test_item - 21 Dec 2025 - Tested successfully
avatar exlemor
exlemor - comment - 21 Dec 2025

I have tested this item ✅ successfully on a4d62f6

I have tested this successfully! Thanks @stefanoel for the fix!

Happy Holidays!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46581.

avatar richard67 richard67 - change - 21 Dec 2025
Status Pending Ready to Commit
Labels Added: bug PR-5.4-dev
avatar richard67
richard67 - comment - 21 Dec 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46581.

avatar muhme muhme - change - 8 Jan 2026
Labels Added: RTC
avatar muhme
muhme - comment - 8 Jan 2026

✅ Final test before merge with JBT

  • Seen the problem before PR
  • Applied PR with gh pr checkout 46581
  • Problem with sub menu fixed in both languages, main menu level still working, sub-sub-menu level is also working
avatar muhme muhme - change - 8 Jan 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-01-08 06:38:41
Closed_By muhme
avatar muhme muhme - close - 8 Jan 2026
avatar muhme muhme - merge - 8 Jan 2026
avatar muhme
muhme - comment - 8 Jan 2026

Thank you @stefanoel for your contribution. Thank you @alikon and @exlemor for testing.

Add a Comment

Login with GitHub to post a comment