Updates Requested NPM Resource Changed PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar PranjalManhgaye
PranjalManhgaye
9 Dec 2025

Pull Request for Issue #46015

Summary of Changes

Improve checkbox visibility in dark mode by adjusting the background color to enhance visual distinction from buttons.

Testing Instructions

  1. Switch to dark mode in Joomla admin
  2. Navigate to any form with checkboxes (e.g., Global Configuration, Article Manager filters)
  3. Verify that checkboxes are now more visible and distinct from buttons
  4. Test hover and active states to ensure proper contrast

Actual result BEFORE applying this Pull Request

  • Checkboxes in dark mode had the same background color as buttons (#007DB0)
  • Poor visual distinction between checkboxes and buttons
  • Reduced accessibility and user experience in dark mode

Expected result AFTER applying this Pull Request

  • Checkboxes now have a distinct color (#3A7BBF) in dark mode
  • Better visual hierarchy between form elements
  • Improved accessibility and user experience
  • Maintained consistency with the dark theme

Link to documentations

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Note: This PR includes some metadata changes in package-lock.json and cli/joomla.php that don't affect functionality. The main change is in _variables-dark.scss.

avatar PranjalManhgaye PranjalManhgaye - open - 9 Dec 2025
avatar PranjalManhgaye PranjalManhgaye - change - 9 Dec 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Dec 2025
Category Repository NPM Change CLI
avatar PranjalManhgaye PranjalManhgaye - change - 9 Dec 2025
Labels Added: NPM Resource Changed PR-5.4-dev
avatar brianteeman
brianteeman - comment - 9 Dec 2025

Note: This PR includes some metadata changes in package-lock.json and cli/joomla.php that don't affect functionality. The main change is in _variables-dark.scss.

They must be removed from the pr

avatar richard67
richard67 - comment - 9 Dec 2025

Note: This PR includes some metadata changes in package-lock.json and cli/joomla.php that don't affect functionality. The main change is in _variables-dark.scss.

They must be removed from the pr

@PranjalManhgaye Brian is right. Any unrelated changes need to be reverted. This applied to the package-lock.json changes and to the mode change of the cli/joomla.php file.

avatar brianteeman
brianteeman - comment - 9 Dec 2025

I do not see the need for this change and to me it is aesthetically displeasing to see a slight difference between the buttons and the checked checkbox. What are you trying to achieve with this pr. I cant believe anyone would ever confuse a checked checkbox and a button

avatar PranjalManhgaye PranjalManhgaye - change - 9 Dec 2025
Labels Added: Updates Requested
avatar PranjalManhgaye
PranjalManhgaye - comment - 9 Dec 2025

Thanks for reviewing,
the intention of the change was to improve visual consistency and make the active state more distinguishable.
However, if the team feels this isn’t aligned with the design philosophy, i'm happy to discuss alternatives or close this PR
Please let me know how you’d like to proceed

avatar richard67
richard67 - comment - 9 Dec 2025

@PranjalManhgaye We will discuss your PR soon and let you know when there is a decision.

But a general hint: When making pull request you should always check the changed files on GitHub.

If you would do that for this PR here https://github.com/joomla/joomla-cms/pull/46552/files you could see that it shows a change of the file system permissions for file cli/joomla.php . This change is unrelated and has to be reverted. I told you in my previous comment but it seems you've missed that.

avatar PranjalManhgaye PranjalManhgaye - change - 10 Dec 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-12-10 04:40:13
Closed_By PranjalManhgaye
avatar PranjalManhgaye PranjalManhgaye - close - 10 Dec 2025

Add a Comment

Login with GitHub to post a comment