User tests: Successful: Unsuccessful:
Improve checkbox visibility in dark mode by adjusting the background color to enhance visual distinction from buttons.
Note: This PR includes some metadata changes in package-lock.json and cli/joomla.php that don't affect functionality. The main change is in _variables-dark.scss.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Repository NPM Change CLI |
| Labels |
Added:
NPM Resource Changed
PR-5.4-dev
|
||
Note: This PR includes some metadata changes in package-lock.json and cli/joomla.php that don't affect functionality. The main change is in _variables-dark.scss.
They must be removed from the pr
@PranjalManhgaye Brian is right. Any unrelated changes need to be reverted. This applied to the package-lock.json changes and to the mode change of the cli/joomla.php file.
I do not see the need for this change and to me it is aesthetically displeasing to see a slight difference between the buttons and the checked checkbox. What are you trying to achieve with this pr. I cant believe anyone would ever confuse a checked checkbox and a button
| Labels |
Added:
Updates Requested
|
||
Thanks for reviewing,
the intention of the change was to improve visual consistency and make the active state more distinguishable.
However, if the team feels this isn’t aligned with the design philosophy, i'm happy to discuss alternatives or close this PR
Please let me know how you’d like to proceed
@PranjalManhgaye We will discuss your PR soon and let you know when there is a decision.
But a general hint: When making pull request you should always check the changed files on GitHub.
If you would do that for this PR here https://github.com/joomla/joomla-cms/pull/46552/files you could see that it shows a change of the file system permissions for file cli/joomla.php . This change is unrelated and has to be reverted. I told you in my previous comment but it seems you've missed that.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-12-10 04:40:13 |
| Closed_By | ⇒ | PranjalManhgaye |
They must be removed from the pr