[#46542] - [5.4] Do not load articles in blog layout if configured
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 46542
- Diff
- joomdonation:fix_category_blog_zero_articles
User tests: Successful: Unsuccessful:
Pull Request for Issue #46447, #18529 .
Summary of Changes
At the moment, for Category Blog menu item type, Joomla still loads articles if total number of articles configured for that menu item = 0. This PR just fixed that wrong behavior, see the linked issues to understand more details
Testing Instructions
- Create two menu items, one links to Category Blog Layout menu item type and one to Category List menu item type.
- Apply patch, confirm that two menu items still display articles same as before.
- We will also needs confirmation from the author of the two issues confirm that the issue fixed
Actual result BEFORE applying this Pull Request
Works, but Joomla still query database to get articles when it is not needed, thus cause potential performance issue
Expected result AFTER applying this Pull Request
Works, no unnecessary query executed anymore if the menu item is configured to not show any articles
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
@brianteeman That's not a problem. The issue of this PR is tied to the Category Menu Item. The issue resides on the fact that, when putting 0 on all article fields in the Category Menu Item, it will display 0 articles (this is already the case, so no inconsistency here, it already always worked like this) but it still queries in the background the data from all articles, causing super slow loading despite showing the intended 0 articles at the end.
@joomdonation Thanks, I'll test this and report back.
I have tested this item ✅ successfully on 675eb71
Thank you, after over 8 years, I confirm this fixes the issue :D
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46542.
Sorry you missed the point I was trying to make. In the module 0 = everything but in the component 0= nothing
Sorry you missed the point I was trying to make. In the module 0 = everything but in the component 0= nothing
No, I perfectly got your point. But your point has nothing to do with this PR or the issue is trying to fix.
Fair enough
I have tested this item ✅ successfully on 675eb71
I have tested this successfully. Thanks @joomdonation.
I turned on Debug, I had expected to see fewer queries but I got the same amount with or without the PR:
15 statements were executed, 2 of which were duplicates, 13 unique
(I assume that's fine, just thought I'd mention it just in case).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46542.
| Labels |
Added:
PR-5.4-dev
|
||
I turned on Debug, I had expected to see fewer queries but I got the same amount with or without the PR:
Yes. The queries should be fewer because we do not have to query database to get articles data. In my sample setup, before the change, there is 51 queries. After the change, only 42 queries (but my local site contains mix of things, not just fresh Joomla installation
I have tested this item ✅ successfully on b6b868c
Confirm it still works after the new update.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46542.
I have tested this item ✅ successfully on b6b868c
I have re-tested this successfully. Thanks for your due diligence @joomdonation
In my case, still the same results BEFORE and AFTER applying the PR and clearing cache.
15 statements were executed, 2 of which were duplicates, 13 unique
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46542.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46542.
The problem is that in other areas setting to 0 means all articles eg in mod_articles