RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
6 Dec 2025

Pull Request for Issue #46533.

Summary of Changes

Action Logs - Latest module does not load language for the extension associated with the log item and it could cause the message not being translated. This PR fixes that small issue

Testing Instructions

The issue only happens with third party extension as described here which unfortunately, not available for testing. So you can just make sure the module is still working as before with this PR applied. Plus, if you know code, you can do review the code change here with the code use in actions log component https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/components/com_actionlogs/tmpl/actionlogs/default.php#L79-L80

  • Uses Joomla 5.4
  • Load an instance of Action Logs - Latest module in Home Dashboard from administrator area of your site
  • Make sure that the action log messages still being displayed OK.

Actual result BEFORE applying this Pull Request

  • Some action logs message not being displayed properly due to extension language file not being loaded

Expected result AFTER applying this Pull Request

  • All action log message displayed properly

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomdonation joomdonation - open - 6 Dec 2025
avatar joomdonation joomdonation - change - 6 Dec 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Dec 2025
Category Modules Administration
avatar dmb0058
dmb0058 - comment - 6 Dec 2025

Lines 78 and 79 in the PR are the same as the lines in the existing file?

This is the original installation administrator/components/com_actionlogs//tmpl/actionlogs/default.php:

79                         $extension = strtok($item->extension, '.');
80                         ActionlogsHelper::loadTranslationFiles($extension); ?>
avatar joomdonation
joomdonation - comment - 6 Dec 2025

@dmb0058 Yes, that's right. But administrator/components/com_actionlogs//tmpl/actionlogs/default.php is for component, the module does not have that similar lines and I believe that's the reason causing the issue. Could you check to see if the change in this PR address your issue?

avatar dmb0058
dmb0058 - comment - 6 Dec 2025

Ahh I see, sorry. I noticed that administrator/modules/mod_latestactions/tmpl/default.php doesn't have the ActionHelper lines but I was looking at the wrong place for the PR (github_newbie :))

I applied the patch and it works perfectly - thank you 🥇

avatar joomdonation
joomdonation - comment - 6 Dec 2025

Great. Could you please go to https://issues.joomla.org/tracker/joomla-cms/46540 and report your test result? We require two successful tests for each PR before it can be merged

avatar dmb0058
dmb0058 - comment - 6 Dec 2025

I have 42 actions logged throughout my component.

Before applying the patch none of the translated strings appeared in the "Latest Actions" module on the Home Dashboard, instead the message keys were reported.

After applying the patch each of the 42 translated strings are now correctly displayed with the username and action/item inserted.

Is this enough to merge the PR?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46540.

avatar dmb0058 dmb0058 - test_item - 6 Dec 2025 - Tested successfully
avatar dmb0058
dmb0058 - comment - 6 Dec 2025

I have tested this item ✅ successfully on 8b0ab38

I have 42 actions logged throughout my component.

Before applying the patch none of the translated strings appeared in the "Latest Actions" module on the Home Dashboard, instead the message keys were reported.

After applying the patch each of the 42 translated strings are now correctly displayed with the username and action/item inserted.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46540.

avatar dmb0058 dmb0058 - test_item - 6 Dec 2025 - Tested successfully
avatar dmb0058
dmb0058 - comment - 6 Dec 2025

I have tested this item ✅ successfully on 8b0ab38

I have 12 actions logged in my second component.

Before applying the patch none of the translated strings appeared in the "Latest Actions" module on the Home Dashboard, instead the message keys were reported.

After applying the patch each of the 12 translated strings are now correctly displayed with the username and action/item inserted.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46540.

avatar exlemor
exlemor - comment - 7 Dec 2025

Is this enough to merge the PR?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46540.

Hello @dmb0058, there will need to be a 2nd test minimum for the maintainers to be able for the PR to be RTC and merged once the maintainers team evaluate/decide to include it in the next/appropriate release.

Thank you for reporting the issue and for the test.

avatar richard67
richard67 - comment - 8 Dec 2025

@joomdonation Does this replace PR #44108 by @Ruud68 ? Or is that a different issue?

avatar joomdonation
joomdonation - comment - 8 Dec 2025

@richard67 I believe it is the same issue, just different approach. The approach here is already uses in the component, and in the CSV export, so I would use this PR.

avatar richard67
richard67 - comment - 8 Dec 2025

Yes, the PR here seems more elegant to me.

avatar exlemor exlemor - test_item - 8 Dec 2025 - Tested successfully
avatar exlemor
exlemor - comment - 8 Dec 2025

I have tested this item ✅ successfully on 8b0ab38

I have tested this I believe successfully... To be clear, since I don't have that 3rd party extension to test with, I was able confirm that the Actions Module looks the same BEFORE and AFTER, no console errors or errors on the screen, everything seems to display correctly AFTER. I should add, Error Reporting set to Maximum, Debug: on, multilingual site.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46540.

avatar richard67 richard67 - change - 8 Dec 2025
Status Pending Ready to Commit
Labels Added: bug PR-5.4-dev
avatar richard67
richard67 - comment - 8 Dec 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46540.

avatar muhme muhme - change - 9 Dec 2025
Labels Added: RTC
avatar muhme
muhme - comment - 9 Dec 2025

✅ Final test before merge with JBT

  • System > Languages > Installed de-DE as second language
  • Compared 'Latest Actions' (only the system actions, w/o 3rd party) before and after PR and once with en-GB and once with de-DE
avatar muhme muhme - change - 9 Dec 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-12-09 17:06:59
Closed_By muhme
avatar muhme muhme - close - 9 Dec 2025
avatar muhme muhme - merge - 9 Dec 2025
avatar muhme
muhme - comment - 9 Dec 2025

Thank you @joomdonation for your contribution. Thank you @dmb0058 and @exlemor for testing.

avatar joomdonation
joomdonation - comment - 10 Dec 2025

Thanks to all !

Add a Comment

Login with GitHub to post a comment