Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#46527] - [5.4] Remove unnecessary $this->setError('')

RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
2 Dec 2025

Summary of Changes

Turns out that somehow we have very old code that by default sets an (empty) error each time we save something or publish a nested entity. This triggers the new code for useException. This removes these unnecessary commands.

Testing Instructions

codereview...

Actual result BEFORE applying this Pull Request

Everything works.

Expected result AFTER applying this Pull Request

Everything works like before.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 2 Dec 2025
avatar Hackwar Hackwar - change - 2 Dec 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Dec 2025
Category ⇒ Libraries
avatar alikon alikon - test_item - 5 Dec 2025 - Tested successfully
avatar alikon
alikon - comment - 5 Dec 2025

I have tested this item ✅ successfully on 2b63c74

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46527.

avatar chmst chmst - test_item - 13 Dec 2025 - Tested successfully
avatar chmst
chmst - comment - 13 Dec 2025

I have tested this item ✅ successfully on 2b63c74

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46527.

avatar chmst
chmst - comment - 13 Dec 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46527.

avatar richard67 richard67 - change - 13 Dec 2025
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 13 Dec 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46527.

avatar muhme muhme - change - 13 Dec 2025
Labels Added: RTC bug PR-5.4-dev
avatar muhme
muhme - comment - 14 Dec 2025

Test result:

  • ✅ Checked with find . -name \*.php | xargs /usr/bin/grep "\$this->setError[(]''[)]" only the three removed entries are found in our code (and three more in libraries/vendor/phpmailer/phpmailer/src/SMTP.php)
  • I tried to find actions by setting PR breakpoints at the three locations, but I couldn't stop at any of the three locations with xdebug. For example, I created and published articles. Therefore, I don't know what to test after applying the PR. In my opinion, system tests are sufficient in this case. Or do you have any tips?
avatar richard67 richard67 - close - 17 Dec 2025
avatar richard67 richard67 - merge - 17 Dec 2025
avatar richard67 richard67 - change - 17 Dec 2025
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-12-17 18:48:44
Closed_By ⇒ richard67
avatar richard67
richard67 - comment - 17 Dec 2025

Thanks @Hackwar for this fix, and thanks @alikon , @chmst and @muhme for testing.

Add a Comment

Login with GitHub to post a comment